-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remember last exported preferences #2153
Conversation
# Conflicts: # src/main/java/net/sf/jabref/gui/preftabs/PreferencesDialog.java
Looks good! Would it make sense to store the location to the preferences so it is consistent between sessions? |
Yes, I think @oscargus is right and it make sense to store this in the preferences (we already have something similar in place for import/export of bib files. I think it is called |
I've stored it now in the preferences and added a changelog entry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just remove the unnecessary variable and merge.
@@ -63,6 +63,7 @@ | |||
private final JButton showPreferences = new JButton(Localization.lang("Show preferences")); | |||
|
|||
private final JButton resetPreferences = new JButton(Localization.lang("Reset preferences")); | |||
private Path lastExportedPath; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed. Travis is failing, but that doesn't seem to be related to this PR.
fixes/implements #97
Now if the preferences are exported and later import preferences is choosen, then the explorer will start where the preferences are last exported.