Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember last exported preferences #2153

Merged
merged 6 commits into from
Oct 18, 2016
Merged

Conversation

tschechlovdev
Copy link
Contributor

fixes/implements #97
Now if the preferences are exported and later import preferences is choosen, then the explorer will start where the preferences are last exported.

# Conflicts:
#	src/main/java/net/sf/jabref/gui/preftabs/PreferencesDialog.java
@boceckts boceckts added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers and removed stupro-ready-for-internal-review labels Oct 11, 2016
@boceckts boceckts changed the title [WIP] Remember last exported preferences Remember last exported preferences Oct 11, 2016
@oscargus
Copy link
Contributor

Looks good! Would it make sense to store the location to the preferences so it is consistent between sessions?

@tobiasdiez
Copy link
Member

Yes, I think @oscargus is right and it make sense to store this in the preferences (we already have something similar in place for import/export of bib files. I think it is called working directory). Please also add a changelog entry.

@tobiasdiez tobiasdiez removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 12, 2016
@tschechlovdev tschechlovdev added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 13, 2016
@tschechlovdev
Copy link
Contributor Author

I've stored it now in the preferences and added a changelog entry.

Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just remove the unnecessary variable and merge.

@@ -63,6 +63,7 @@
private final JButton showPreferences = new JButton(Localization.lang("Show preferences"));

private final JButton resetPreferences = new JButton(Localization.lang("Reset preferences"));
private Path lastExportedPath;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed. Travis is failing, but that doesn't seem to be related to this PR.

@tobiasdiez tobiasdiez removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants