Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Datepicker "none"-button #2122

Merged
merged 2 commits into from
Oct 5, 2016
Merged

Implement Datepicker "none"-button #2122

merged 2 commits into from
Oct 5, 2016

Conversation

lenhard
Copy link
Member

@lenhard lenhard commented Oct 5, 2016

Fixes #2092

Implemented behavior for the "none"-button of the data picker, which now clears the content of the date field.

  • Change in CHANGELOG.md described
  • Manually tested changed features in running JabRef

@lenhard lenhard added [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs component: ui labels Oct 5, 2016
@lenhard lenhard added this to the v3.7 milestone Oct 5, 2016
@lenhard lenhard added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 5, 2016
@lenhard lenhard changed the title Datepicker none Implement Datepicker "none"-button Oct 5, 2016
Copy link
Member

@matthiasgeiger matthiasgeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@tobiasdiez
Copy link
Member

LGTM.
Thanks for your contribution 😃

@tobiasdiez tobiasdiez merged commit 998fb28 into master Oct 5, 2016
@tobiasdiez tobiasdiez deleted the datepicker-none branch October 5, 2016 18:20
Siedlerchr added a commit that referenced this pull request Oct 9, 2016
* upstream/master: (102 commits)
  Removed unused test code (#2140)
  Fix main table bug when creating a duplicate (#2135)
  Remove explicit author and add SPDX-License-Identifier
  Remove GPL from README.md and CONTRIBUTING.md
  fix preview update (#2125)
  Remove some UnicodeToLatex uses (#2132)
  Fix mixup in french/farsi localization
  FetcherException should extend JabRefException
  Fix exception when opening preference dialog (#2127)
  Unify ParserException and ParseException (#2124)
  Small refactoring in Importer package (#2053)
  Implement Datepicker "none"-button (#2122)
  revert change from 816d30c
  Change title/tooltip of source panel in biblatex mode (#2120)
  Refactoring: completey typed metadata and add detailed travis output (#2112)
  RTFchars fix (#2097)
  Fix NPE in Medline fetcher on missing ISSN (#2113)
  Ctrl-s parsing error message (#2114)
  Fix bad web search error messages (#2034)
  parse error freeze (#2106)
  ...

# Conflicts:
#	src/main/java/net/sf/jabref/collab/FileUpdateMonitor.java
#	src/main/java/net/sf/jabref/gui/externalfiles/DownloadExternalFile.java
#	src/main/java/net/sf/jabref/gui/externalfiles/DroppedFileHandler.java
#	src/main/java/net/sf/jabref/gui/externalfiles/MoveFileAction.java
#	src/main/java/net/sf/jabref/logic/cleanup/RenamePdfCleanup.java
#	src/main/java/net/sf/jabref/logic/exporter/FileSaveSession.java
#	src/main/java/net/sf/jabref/logic/util/io/FileUtil.java
#	src/main/java/net/sf/jabref/preferences/JabRefPreferences.java
zesaro pushed a commit to zesaro/jabref that referenced this pull request Nov 22, 2016
* "none"-button in date picker should clear the field

* Add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ui [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants