Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Speed up search #2091

Closed
wants to merge 2 commits into from
Closed

[WIP] Speed up search #2091

wants to merge 2 commits into from

Conversation

chriba
Copy link
Contributor

@chriba chriba commented Sep 29, 2016

Refers to: #1993

At the request of @koppor I speed up the search by using a second map of fields inside BibEntry which stores the field latex free.
I also internalize these fields and set the necessary JVM arguments in install4j (I hope those are right).

TODO:

  • Identifiy all the uses of the LatexToUnicodeFormatter and replace it.

@chriba chriba changed the title Speed up search [WIP] Speed up search Sep 29, 2016
@koppor
Copy link
Member

koppor commented Sep 29, 2016

This PR breaks our architecture. Do we need a more sophisticated solution?

net.sf.jabref.ArchitectureTests > fistPackageIsIndependentOfSecondPackage[7 -- is net.sf.jabref.model independent of net.sf.jabref.logic?] FAILED

    java.lang.AssertionError: expected:<[]> but was:<[src/main/java/net/sf/jabref/model/entry/BibEntry.java]>

@lenhard
Copy link
Member

lenhard commented Sep 29, 2016

@koppor "Could have told you so" ;-) The architecture issue was pretty obvious here. Let us talk this through before implementing a quick shot, I have a number of solutions on my mind to this architecture stuff, as well as for the rest.

Let us also keep in mind that the VM args might not be quite be as portable or effective for non-Oracle JVMs.

@oscargus
Copy link
Contributor

Just use LatexToUnicode instead of LatexToUnicodeConverter...

@lenhard
Copy link
Member

lenhard commented Sep 29, 2016

Indeed. At the devcall, we decided to implement basically everything, i.e., cached LaTeX-free fields in BibEntry, String internalization, additional command-line args, and some pre-compilation of regular expression.

I'll hijack this PR and create a new one shortly, albeit not today.

@lenhard lenhard mentioned this pull request Sep 30, 2016
2 tasks
@lenhard
Copy link
Member

lenhard commented Sep 30, 2016

I have moved over the ideas here into #2102 and build some more on top. Hence, I'll close this PR.

@lenhard lenhard closed this Sep 30, 2016
@chriba chriba deleted the speedUpSearch branch September 30, 2016 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants