Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented BibtexkeyChecker #2022

Merged
merged 6 commits into from
Sep 22, 2016
Merged

Implemented BibtexkeyChecker #2022

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
69c4717
BibtexkeyChecker
Sep 20, 2016
68adcaa
CHANGELOG.md and tests
Sep 21, 2016
f370908
Changes 1
Sep 21, 2016
7d7ec00
checkstyle
Sep 21, 2016
d4f6ee9
Change 2
Sep 21, 2016
c73c408
Change 3
Sep 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#
- <kbd>UP</kbd> / <kbd>Down</kbd> / <kbd>Tab</kbd> / <kbd>shift+Tab</kbd> in the search result frame have now the same functionality as in the main table.
- Importer for MODS format added
- [#2012](https://github.com/JabRef/jabref/issues/2012) Implemented integrity check for `month` field: Should be an integer or normalized (BibLaTeX), Should be normalized (BibTeX)
- [#1779](https://github.com/JabRef/jabref/issues/1779) Implemented integrity check for `bibtexkey` field: Empty bibtexkey

### Fixed
- Fixed selecting an entry out of multiple duplicates
Expand Down
6 changes: 6 additions & 0 deletions src/test/java/net/sf/jabref/logic/integrity/IntegrityCheckTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,12 @@ public void testMonthChecks() {
assertWrong(withMode(createContext("month", "Lorem"), BibDatabaseMode.BIBLATEX));
}

@Test
public void testBibtexkeyChecks() {
assertCorrect(createContext("bibtexkey", "Knuth2014"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you do one assertCorrect per Test please? 😇

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we now have a class for each checker, we should also create a test class for each checker separately.
But I would think that is content for a new PR

Copy link
Contributor Author

@grimes2 grimes2 Sep 22, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed my thumb up. A separate test class for every checker is too much (for evt. one or two entries). I think, it is better to organize the checker tests by fields (in methods) and not by checker classes.

assertCorrect(createContext("bibtexkey", ""));
}

@Test
public void testBracketChecks() {
assertCorrect(createContext("title", "x"));
Expand Down