Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracted native Windows logic and fixed #194 #197

Merged
merged 3 commits into from
Oct 6, 2015
Merged

Conversation

stefan-kolb
Copy link
Member

This should fix the problem with Windows XP and Vista being unable to use the pin to taskbar feature.
However, I'm not certain if the feature works on Windows 7 and up.
My first tests on Windows 10 didn't allow me to pin JabRef.
We need to investigate this.

Likewise, we should also extract other OS-dependent logic from our code.

@stefan-kolb stefan-kolb added this to the v2.80 milestone Oct 1, 2015
@stefan-kolb
Copy link
Member Author

Functionality also seems broken.
Looks like the WinShell plugin is not working in our current setup.
I cannot find the AppUserModelID inside our *.lnk" file.
See http://stackoverflow.com/questions/5438651/launch4j-nsis-and-duplicate-pinned-windows-7-taskbar-icons

Our dev version number also breaks this functionality VERSION--snapshot--DATE--GIT_HASH

Are we using the unicode version of NSIS?

@simonharrer
Copy link
Contributor

As far as I know we do not use the unicode version of NSIS, but the older one instead.
NSIS 2.46 instead of 3.0b2

I am not sure if this ever worked. But it would be really helpful on windows machines.

@stefan-kolb
Copy link
Member Author

Should work correctly now.
It also shows a pin to taskbar option when right clicking on the exe file.

However, the pin option in the menu is not showing up for a running instance.
http://stackoverflow.com/questions/1834599/pinning-a-java-application-to-the-windows-7-taskbar
https://msdn.microsoft.com/en-us/library/dd378459(VS.85).aspx#host

@stefan-kolb
Copy link
Member Author

Possible further taskbar stuff:
https://msdn.microsoft.com/en-us/library/dd378460(v=vs.85).aspx

@stefan-kolb stefan-kolb modified the milestones: v2.11, v2.80 Oct 2, 2015
@simonharrer
Copy link
Contributor

Is there a use case to have different JabRef versions installed separately? Because we could just use the String "JabRef" for the AppID. Then, we do not need to pass around the current version number. This would make things a lot easier.

@mlep
Copy link
Contributor

mlep commented Oct 5, 2015

Useful for working with a version, and testing another one, no?

@koppor
Copy link
Member

koppor commented Oct 5, 2015

I think, testing can be done using java -jar. Other applications also don't enable installing of two different versions. This might also get difficult when having preferences updated (and downgraded?!)

simonharrer added a commit that referenced this pull request Oct 6, 2015
Extracted native Windows logic and fixed #194
@simonharrer simonharrer merged commit 20284d2 into master Oct 6, 2015
@stefan-kolb stefan-kolb deleted the win-pintaskbar branch October 6, 2015 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants