-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extracted native Windows logic and fixed #194 #197
Conversation
d0d6789
to
cb74230
Compare
Functionality also seems broken. Our dev version number also breaks this functionality Are we using the unicode version of NSIS? |
cb74230
to
ff4ae0e
Compare
As far as I know we do not use the unicode version of NSIS, but the older one instead. I am not sure if this ever worked. But it would be really helpful on windows machines. |
Should work correctly now. However, the pin option in the menu is not showing up for a running instance. |
Possible further taskbar stuff: |
Is there a use case to have different JabRef versions installed separately? Because we could just use the String "JabRef" for the AppID. Then, we do not need to pass around the current version number. This would make things a lot easier. |
Useful for working with a version, and testing another one, no? |
I think, testing can be done using |
Extracted native Windows logic and fixed #194
This should fix the problem with Windows XP and Vista being unable to use the pin to taskbar feature.
However, I'm not certain if the feature works on Windows 7 and up.
My first tests on Windows 10 didn't allow me to pin JabRef.
We need to investigate this.
Likewise, we should also extract other OS-dependent logic from our code.