Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #1804: URL field is not removed by integrity check #1823

Merged
merged 1 commit into from
Aug 23, 2016
Merged

Conversation

oscargus
Copy link
Contributor

@oscargus oscargus commented Aug 23, 2016

Better to disable the check than remove the field from the entry. ;-)

Fixes #1804

  • Change in CHANGELOG.md described
  • Tests created for changes (one may think of adding a test that no fields are removed from the entry in the integrity check, but I haven't done that here, ideally the entry should have every possible field included...)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@oscargus oscargus added bug Confirmed bugs or reports that are very likely to be bugs status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers integrity-checker labels Aug 23, 2016
@oscargus oscargus added this to the v3.6 milestone Aug 23, 2016
@matthiasgeiger
Copy link
Member

LGTM

@stefan-kolb stefan-kolb merged commit 21069a4 into master Aug 23, 2016
@stefan-kolb stefan-kolb deleted the fix1804 branch August 23, 2016 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs integrity-checker status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants