Move bst package to logic #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenhard
added
cleanup-ops
status: ready-for-review
| @@ -12,6 +12,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `# | |||
| ## [Unreleased] | |||
|
|
|||
| ### Changed | |||
| - Moved the bst package into logic. For developers: This requires the regeneration of antlr sources, execute: gradlew generateSource | |||
There was a problem hiding this comment.
One could argue if this should be in the change log as it is mainly a code issue. However, as there are some earlier entries like that and there is the need of antlr source regeneration it might just as well stay there.
There was a problem hiding this comment.
Perhaps just start the whole entry with "For developers: ..."
There was a problem hiding this comment.
@matthiasgeiger: Done. And I will of course squash the commits when merging
|
LGTM! 👍 |
|
LGTM - @lenhard And don't forget to squash 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the
bstpackage from root intologic. This operation is possible without any functional source code change. Moving the package does not break any of our existing dependency tests.However, it requires re-generating the antlr sources (
gradlew generateSource).Refs: #1579