Added button to crossref entry editor field to select parent entry #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
added
type: enhancement
status: ready-for-review
|
Well, now it is more like the actual feature request. The reverse linking is not obvious how to implement graphically and relates to JabRef#14 as well. |
| @@ -474,4 +474,55 @@ public void mouseClicked(MouseEvent e) { | |||
| return Optional.of(gender); | |||
|
|
|||
| } | |||
|
|
|||
| /** | |||
| * Return a button which sets the owner if the field for fields with EXTRA_SET_OWNER | |||
There was a problem hiding this comment.
I think the comment is wrong here.
There was a problem hiding this comment.
Yes, a bit of copy paste coding, like checkURL...
I'll sort it out. "Go to parent" may be a better name, but I wasn't sure
how well defined "parent" actually is here and somehow what happens is that
the parent entry is selected. And couldn't figure out a good translation to
Swedish...
Another issue is that the button is enabled when the entry editor is
enabled. At least for new entries... Once something is typed it works
though. Guess one should try to trigger the documentListener once, but
didn't figure out how...
tobiasdiez
removed
the
status: ready-for-review
|
I kept the button name and didn't understand the lambda thing. Other than that, the comments are honored. |
oscargus
added
the
status: ready-for-review
|
@oscargus Forget about the lambda thing. I oversaw that it contains more than one method 😕 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the idea in #1338 a button is added in the crossref entry editor field to select the parent entry in the main table. It is not exactly the same thing as suggested in #1338 though.