Fixes build for OSX #1481 #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, thanks for your fix! How did you correct this? I just automatically created the icon files with some tool. I wonder what went wrong... |
|
👍 Thanks for fixing! @JabRef/developers shall we release 3.4(.1) for Mac OS X? |
|
I restored the old "JabRef-icon-mac.icns" file - Maybe this tool deletes some OSX specific metadata, because I also had some problems modifying the new file, because it had a dimension of 0x0 instead of 512x512 |
|
Okay... Stefan tries to recreate a valid *.icns file with the "standard logo" which should be used. |
|
Okay I used Greenfish icon editor. Just exported as Mac icon file... |
|
@chochreiner Can you try this icon file and amend it in your branch if it is working? |
|
works fine |
|
Thank you again Christoph 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1481
The metadata of the logo was broken which caused Jabref to be stuck at startup on OSX.