Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REduce log level noise #12200

Merged
merged 1 commit into from
Nov 17, 2024
Merged

REduce log level noise #12200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/main/java/org/jabref/gui/entryeditor/FieldsEditorTab.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ private void addPreviewPanel() {

public void removePreviewPanelFromThisTab() {
assert this.getContent() instanceof SplitPane;
if (this.getContent() instanceof SplitPane splitPane && splitPane.getItems().contains(previewPanel)) {
if (this.getContent() instanceof SplitPane splitPane) {
splitPane.getItems().remove(previewPanel);
// Needed to "redraw" the split pane with one item (because JavaFX does not readjust if it is shown)
// splitPane.setDividerPositions(1.0);
Expand All @@ -260,10 +260,10 @@ public void removePreviewPanelFromThisTab() {

@Override
protected void handleFocus() {
LOGGER.error("This is {}", preferences.getPreviewPreferences().showPreviewAsExtraTabProperty().get());
LOGGER.error("This is then {}", !preferences.getPreviewPreferences().showPreviewAsExtraTabProperty().get());
LOGGER.trace("This is {}", preferences.getPreviewPreferences().showPreviewAsExtraTabProperty().get());
LOGGER.trace("This is then {}", !preferences.getPreviewPreferences().showPreviewAsExtraTabProperty().get());
if (!preferences.getPreviewPreferences().showPreviewAsExtraTabProperty().get()) {
LOGGER.error("Focus on preview panel");
LOGGER.trace("Focus on preview panel");

// We need to move the preview panel from the non-visible tab to the visible tab
removePreviewPanelFromOtherTabs();
Expand Down
Loading