Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract preview panel #12165

Merged
merged 29 commits into from
Nov 10, 2024
Merged

Extract preview panel #12165

merged 29 commits into from
Nov 10, 2024

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Nov 8, 2024 •
edited by koppor
Loading

Fixes #9172

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

calixtus and others added 14 commits September 7, 2024 01:11
@calixtus
initial
d9d596e
@koppor
Add some code comments
465d61c
@koppor
Merge branch 'main' into extract-preview-panel
96a3f69 
# Conflicts:
#	src/main/java/org/jabref/gui/collab/DatabaseChangesResolverDialog.java
#	src/main/java/org/jabref/gui/collab/entrychange/EntryChangeDetailsView.java
#	src/main/java/org/jabref/gui/entryeditor/CommentsTab.java
#	src/main/java/org/jabref/gui/entryeditor/DeprecatedFieldsTab.java
#	src/main/java/org/jabref/gui/entryeditor/DetailOptionalFieldsTab.java
#	src/main/java/org/jabref/gui/entryeditor/EntryEditor.java
#	src/main/java/org/jabref/gui/entryeditor/FieldsEditorTab.java
#	src/main/java/org/jabref/gui/entryeditor/ImportantOptionalFieldsTab.java
#	src/main/java/org/jabref/gui/entryeditor/OptionalFieldsTabBase.java
#	src/main/java/org/jabref/gui/entryeditor/OtherFieldsTab.java
#	src/main/java/org/jabref/gui/entryeditor/PreviewTab.java
#	src/main/java/org/jabref/gui/entryeditor/RequiredFieldsTab.java
#	src/main/java/org/jabref/gui/entryeditor/UserDefinedFieldsTab.java
#	src/main/java/org/jabref/gui/externalfiles/ExternalFilesEntryLinker.java
#	src/main/java/org/jabref/gui/externalfiles/ImportHandler.java
#	src/main/java/org/jabref/gui/maintable/MainTableColumnFactory.java
#	src/main/java/org/jabref/gui/maintable/MainTableTooltip.java
#	src/main/java/org/jabref/gui/openoffice/StyleSelectDialogView.java
#	src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java
#	src/main/java/org/jabref/gui/preview/PreviewPanel.java
#	src/main/java/org/jabref/gui/preview/PreviewViewer.java
#	src/main/java/org/jabref/gui/search/GlobalSearchResultDialog.java
#	src/test/java/org/jabref/gui/entryeditor/CommentsTabTest.java
@koppor
Fix OpenRewrite
60b5ca1
@koppor
Fix checkstyle
8663864
@koppor
Fix CommentsTabTest
4a70fce
@koppor
Merge remote-tracking branch 'origin/main' into extract-preview-panel
b1e9044
@koppor
Try to move
3484d2a
@koppor
Fix imports
5c793ca
@koppor
WIP
f558318
@koppor
Add JavaDoc
24f63aa
@calixtus
Add checks for present PreviewPanel
be10da9
@koppor
Merge branch 'extract-preview-panel' of github.com:JabRef/jabref into…
89ca91c 
… extract-preview-panel
@koppor
Fi xsetCurrentlyEditedEntry
d5bb5bd
@koppor koppor marked this pull request as ready for review November 8, 2024 20:54
@koppor koppor changed the title [WIP] Extract preview panel Extract preview panel Nov 8, 2024
@koppor koppor enabled auto-merge November 9, 2024 00:09
@koppor koppor mentioned this pull request Nov 9, 2024
Closed
2 tasks
@koppor koppor added this pull request to the merge queue Nov 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 10, 2024 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

Merged via the queue into main with commit dc2d300 Nov 10, 2024
26 checks passed
@koppor koppor deleted the extract-preview-panel branch November 10, 2024 18:35
@koppor koppor mentioned this pull request Nov 17, 2024
Merged
7 tasks
@koppor koppor mentioned this pull request Nov 28, 2024
Open
3 tasks
@mulla028 mulla028 mentioned this pull request Nov 28, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koppor koppor koppor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preview out of sync with entry table
2 participants
@calixtus @koppor