Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADR for "entry(s)" #12127

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Add ADR for "entry(s)" #12127

merged 4 commits into from
Oct 31, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented Oct 30, 2024

Add ADR on pluralization.

Risen by #12124 (comment).

This also replaces "entry(ies)" by "entry(s)", which read better IMHO.

Seeign Ukrainian listed at first example at https://cldr.unicode.org/index/cldr-spec/plural-rules, I ask @InAnYan about his oppinion here.

image

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

HoussemNasri
HoussemNasri previously approved these changes Oct 30, 2024
@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 30, 2024
@koppor koppor added this pull request to the merge queue Oct 31, 2024
Merged via the queue into JabRef:main with commit 96d4211 Oct 31, 2024
25 checks passed
@koppor koppor deleted the add-language-adr branch October 31, 2024 20:06
@tobiasdiez
Copy link
Member

A couple of days I actually looked into this myself and found https://support.crowdin.com/icu-message-syntax/#plural. Can we not use this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants