Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSRN urls to CompositeIdFetcher #12021

Merged
merged 7 commits into from
Oct 20, 2024

Conversation

trickypr
Copy link
Contributor

@trickypr trickypr commented Oct 19, 2024

Allows importing (e.g. via pasting) of both short and long SSRN URLs via their associated DOI.

This also removes some dead code that was not cleaned up in #12009.
Closes #11687

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

JabRef#12009 started using CompositeIdFetcher for fetching logic. This removes the dead code functions in ImportHandler
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.

You can check review dog's comments at the tab "Files changed" of your pull request.

Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. All in all, looks good!

@HoussemNasri HoussemNasri added the status: changes required Pull requests that are not yet complete label Oct 19, 2024
@trickypr trickypr requested a review from koppor October 20, 2024 02:10
@koppor koppor added this pull request to the merge queue Oct 20, 2024
@koppor koppor removed the status: changes required Pull requests that are not yet complete label Oct 20, 2024
@koppor
Copy link
Member

koppor commented Oct 20, 2024

@trickypr Thank you for the work! Maybe, you can tackle another issue, too?

Merged via the queue into JabRef:main with commit 0773e4f Oct 20, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable pasting SSRN entries
3 participants