-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SSRN urls to CompositeIdFetcher #12021
Conversation
JabRef#12009 started using CompositeIdFetcher for fetching logic. This removes the dead code functions in ImportHandler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.
You can check review dog's comments at the tab "Files changed" of your pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments. All in all, looks good!
@trickypr Thank you for the work! Maybe, you can tackle another issue, too? |
Allows importing (e.g. via pasting) of both short and long SSRN URLs via their associated DOI.
This also removes some dead code that was not cleaned up in #12009.
Closes #11687
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)