Fix handling of escapings in bracketed patterns #11967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build of this PR is available at https://builds.jabref.org/pull/11967/merge. |
|
The build of this PR is available at https://builds.jabref.org/pull/11967/merge. |
Siedlerchr
reviewed
Oct 15, 2024
CHANGELOG.md
Outdated
| @@ -49,6 +49,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv | |||
| - ⚠️ Renamed command line parameters `embeddBibfileInPdf` to `embedBibFileInPdf`, `writeMetadatatoPdf` to `writeMetadataToPdf`, and `writeXMPtoPdf` to `writeXmpToPdf`. [#11575](https://github.com/JabRef/jabref/pull/11575) | |||
| - The browse button for a Custom theme now opens in the directory of the current used CSS file. [#11597](https://github.com/JabRef/jabref/pull/11597) | |||
| - The browse button for a Custom exporter now opens in the directory of the current used exporter file. [#11717](https://github.com/JabRef/jabref/pull/11717) | |||
| - ⚠️ We relaxed the escaping requirements for [bracketed patterns](https://docs.jabref.org/setup/citationkeypatterns). One only needs to write `\"` if a quote sign should be escaped. All other escapings are not necessary (and working) any more. [#11967](https://github.com/JabRef/jabref/pull/11967) | |||
There was a problem hiding this comment.
These affect also the filename and file directory patterns
Siedlerchr
previously approved these changes
Oct 15, 2024
koppor
added
the
automerge
jabref-machine
approved these changes
Oct 16, 2024
|
The build of this PR is available at https://builds.jabref.org/pull/11967/merge. |
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
ExrosZ
pushed a commit
to ExrosZ/jabref
that referenced
this pull request
Oct 17, 2024
* Add references to other tests * Simplify code * Add test for extracting the first word * Relax escaping * Add link to PR * Add tests Refs JabRef#11367 * Refine CHANGELOG.md * Refine CHANGELOG.md
ExrosZ
pushed a commit
to ExrosZ/jabref
that referenced
this pull request
Oct 17, 2024
* Add references to other tests * Simplify code * Add test for extracting the first word * Relax escaping * Add link to PR * Add tests Refs JabRef#11367 * Refine CHANGELOG.md * Refine CHANGELOG.md
ExrosZ
pushed a commit
to ExrosZ/jabref
that referenced
this pull request
Oct 21, 2024
* Add references to other tests * Simplify code * Add test for extracting the first word * Relax escaping * Add link to PR * Add tests Refs JabRef#11367 * Refine CHANGELOG.md * Refine CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bracketed patterns handling introduced at #3238 (maybe earlier) was very unclear. It required unnecessary escaping and could not deal with
\"in RegEx strings.This PR fixes it.
Twin PR: JabRef/user-documentation#524
This PR refs #11367, because it was triggered by the question there.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)