Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added search for key binds #11953

Merged
merged 3 commits into from
Oct 14, 2024
Merged

added search for key binds #11953

merged 3 commits into from
Oct 14, 2024

Conversation

JasonXuDeveloper
Copy link
Contributor

Closes #11686 - the search bar has been added to filter key binds.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation](https://devdocs.jabref.org/): Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.
image

@JasonXuDeveloper
Copy link
Contributor Author

JasonXuDeveloper commented Oct 14, 2024 •
edited
Loading

@koppor @calixtus I wonder if I should get another review on this PR and approve it?

@koppor koppor enabled auto-merge October 14, 2024 20:39
@koppor koppor added this pull request to the merge queue Oct 14, 2024
Merged via the queue into JabRef:main with commit 363ee2b Oct 14, 2024
23 checks passed
ExrosZ pushed a commit to ExrosZ/jabref that referenced this pull request Oct 17, 2024
@JasonXuDeveloper @calixtus @ExrosZ-Alt
added search for key binds (JabRef#11953)
ed35e20 
* added search for key binds

* use the correct localization key to deal with ellipsis

---------

Co-authored-by: Carl Christian Snethlage <[email protected]>
ExrosZ pushed a commit to ExrosZ/jabref that referenced this pull request Oct 17, 2024
@JasonXuDeveloper @calixtus @ExrosZ-Alt
added search for key binds (JabRef#11953)
3f763ba 
* added search for key binds

* use the correct localization key to deal with ellipsis

---------

Co-authored-by: Carl Christian Snethlage <[email protected]>
ExrosZ pushed a commit to ExrosZ/jabref that referenced this pull request Oct 21, 2024
@JasonXuDeveloper @calixtus @ExrosZ-Alt
added search for key binds (JabRef#11953)
9c47fc4 
* added search for key binds

* use the correct localization key to deal with ellipsis

---------

Co-authored-by: Carl Christian Snethlage <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixtus calixtus calixtus left review comments

@koppor koppor koppor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add search bar for filtering keyboard shortcuts
3 participants
@JasonXuDeveloper @koppor @calixtus