Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate maintable.css to base css #11881

Merged
merged 5 commits into from
Oct 4, 2024
Merged

migrate maintable.css to base css #11881

merged 5 commits into from
Oct 4, 2024

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Oct 4, 2024

add style class for main table

Make @ryan-carpenter happy :)

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

add style class for main table
@Siedlerchr Siedlerchr requested a review from calixtus October 4, 2024 19:52
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 4, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.

You can check review dog's comments at the tab "Files changed" of your pull request.

@calixtus
Copy link
Member

calixtus commented Oct 4, 2024

Did you remove the old maintable.css?

@Siedlerchr
Copy link
Member Author

Yup, it's deleted now and removed the stylesheet loading

Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried. Works good.

I needed to fix an indent.

@koppor koppor enabled auto-merge October 4, 2024 20:40
@koppor koppor added this pull request to the merge queue Oct 4, 2024
Copy link
Contributor

github-actions bot commented Oct 4, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

Merged via the queue into main with commit 3502ba6 Oct 4, 2024
26 checks passed
@koppor koppor deleted the migratemaintabletobasecss branch October 4, 2024 21:05
@Siedlerchr Siedlerchr mentioned this pull request Oct 24, 2024
7 tasks
@koppor
Copy link
Member

koppor commented Nov 11, 2024

This PR destroyed highlighting on mouse over. @koppor Please do more checks when trying out things!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants