Change instances of 'Search Selected' to 'Search Pre-configured'

[plvzfq-rit]

Closes #11866

Instances of 'Search Selected' has been changed to 'Search Pre-configured' in the following files:

• CompositeSearchBasedFetcher.java in line 21
• JabRef_en.properties in line 128
• WebFetchers.java in line 241
• WebSearchTab.fxml in line 30

Mandatory checks

• Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
• Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

[Siedlerchr]

can you lowercase "pre-configured" please?

[plvzfq-rit]

Sure+ Though I'm worried I might have broken something (as shown in the tests)

[plvzfq-rit]

Perhaps something might have been broken since I changed the "Search Selected" to "Select pre-configured" in the FETCHER_NAME field in CompositeSearchBasedFetcher.java?

[plvzfq-rit]

For now, I think I'll try reverting the Fetcher logic back to what it was before so that it still runs.

[plvzfq-rit]

I had reverted the name changes back since not doing so made the dropdown menu display 'Search Selected' instead of 'Search pre-configured.' I do apologize for the hullabaloo;;; Do let me know how to deal with the failed tests though; I am not quite sure how to deal with them and it might affect this branch's ability to merge with the main branch.

[Siedlerchr]

Why do you revert it?

[plvzfq-rit]

Not doing so made the dropdown list display "Search Selected" (the old value) instead of "Search pre-configured"

The dropdown in question (from the latest revert):

[plvzfq-rit]

Though if it was with the revert before that, I was trying to look into the errors that showed up. Though I guess they were quite moot now that I know they're optional

[Siedlerchr]

If you click on Details on the right and check the failures, you will see that the failures are not related to your changes
In addition, Fetcher tests are marked as optional (they depend on external sources and can fail from time to time)

[koppor]

Sure+ Though I'm worried I might have broken something (as shown in the tests)

The fetcher tests run as soon something is changed in the fetchers. Since they are remote services, something might fail - not because of us, but because of the network or the external server. You experience that now.

jabref/.github/workflows/tests-fetchers.yml

Line 8 in 237c36b

- 'src/main/java/org/jabref/logic/importer/fetcher/**'

We execute fetcher tests with the gradle task "fetcherTest"

jabref/.github/workflows/tests-fetchers.yml

Line 58 in 237c36b

run: ./gradlew fetcherTest

As follow-up, maybe, you could write some text to https://devdocs.jabref.org/code-howtos/fetchers.html - and link the new heading from https://devdocs.jabref.org/code-howtos/testing.html? Some lines are OK.

[plvzfq-rit]

Some changes to those devdocs then with regard to fetcherTests? Alright, I'll see what I could do+