Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask for enable indexing when clicking fulltext search #11854

Merged
merged 7 commits into from
Sep 29, 2024
Merged

Ask for enable indexing when clicking fulltext search #11854

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8a712fe
Ask for enable indexing when clicking fulltext search
Siedlerchr Sep 29, 2024
cfbcc3b
only set preferences value
Siedlerchr Sep 29, 2024
457e546
fix flag
Siedlerchr Sep 29, 2024
2b9b8c4
deselect button if not enabled
Siedlerchr Sep 29, 2024
fa27454
switch to listener
Siedlerchr Sep 29, 2024
ff14bbc
fix rewrite
Siedlerchr Sep 29, 2024
1919d61
Update src/main/java/org/jabref/gui/search/GlobalSearchBar.java
Siedlerchr Sep 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/jabref/gui/search/GlobalSearchBar.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ public GlobalSearchBar(LibraryTabContainer tabContainer,
}

private void initSearchModifierButtons() {
fulltextButton.setSelected(searchPreferences.isFulltext());
fulltextButton.setSelected(searchPreferences.isFulltext() && filePreferences.shouldFulltextIndexLinkedFiles());
Siedlerchr marked this conversation as resolved.
Show resolved Hide resolved
fulltextButton.setTooltip(new Tooltip(Localization.lang("Fulltext search")));
initSearchModifierButton(fulltextButton);
fulltextButton.selectedProperty().addListener((obs, oldVal, newVal) -> {
Expand Down