-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert Inner classes to record classes #11838
convert Inner classes to record classes #11838
Conversation
- Inner classes like ComparableMark can be converted to record classes. - most of them can't change it since there are a method in it or changed the record value, which against the purpose of record.
* group : A list of consecutive citation groups only separated by spaces. | ||
* groupCursor : A cursor covering the XTextRange of each entry in group (and the spaces between them) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this @param
?
fix missing at param
this.groupCursor = groupCursor; | ||
} | ||
/** | ||
* @param group : A list of consecutive citation groups only separated by spaces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the correct syntax
https://www.oracle.com/technical-resources/articles/java/javadoc-tool.html#format
Discussion at https://stackoverflow.com/a/16138292/873282
If you want, you can search whether checkstyle supports JavaDoc checks or if there are other ways to check for wrong syntax.
Note that IntelliJ should align the text - which is not the case in your thing. If you mark the two lines and press Ctrl+Alt+L, what happens?
fix javdoc format
I don't see a merge queue option here. All tests are green. Thus, I am directly merging. |
@subhramit The update did go into your |
Co-authored-by: leaf-soba <[email protected]>
ComparableMark
can be converted to record classes.Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)