Fix group chat history and group embeddings generation #11795
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.
You can check review dog's comments at the tab "Files changed" of your pull request.
| @@ -79,7 +80,8 @@ public Void call() throws Exception { | |||
| linkedFiles | |||
| .stream() | |||
| .map(processingInfo -> { | |||
| processingInfo.setState(ProcessingState.PROCESSING); | |||
| UiTaskExecutor.runInJavaFXThread(() -> processingInfo.setState(ProcessingState.PROCESSING)); | |||
There was a problem hiding this comment.
This is the wrong place, see my other PR
There was a problem hiding this comment.
Hmmm, I see.
But I had an exception on this line. Maybe I'll investigate the bug further later. I'll just focus on group chat history in this PR
There was a problem hiding this comment.
The exception comes because we access the UI, but at this point we are in "logic" and we cannot use UI In logic, thus we need to go the point in the UI where the notification is triggered.
|
Okay, now group chat history is stored |
There was a problem hiding this comment.
Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.
You can check review dog's comments at the tab "Files changed" of your pull request.
|
can you address this one as well? https://github.com/JabRef/jabref-issue-melting-pot/issues/542 |
Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/544.
Group chat history wasn't saved. Fixed.
And there was also a problem with embeddings generation for group. One statement should be in JavaFX thread. Fixed.
Mandatory checks
- [ ] Change inCHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)- [ ] Tests created for changes (if applicable)- [ ] Screenshots added in PR description (for UI changes)