Add setting: always add "Cited on pages" text to JStyles.

CHANGELOG.md

@@ -11,6 +11,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 
 ### Added
 
+- We added a setting which always adds the literal "Cited on pages" text before each JStyle citation. [#11691](https://github.com/JabRef/jabref/pull/11732)
 - We added probable search hits instead of exact matches. Sorting by hit score can be done by the new score table column. [#11542](https://github.com/JabRef/jabref/pull/11542)
 - We added support finding LaTeX-encoded special characters based on plain Unicode and vice versa. [#11542](https://github.com/JabRef/jabref/pull/11542)
 - When a search hits a file, the file icon of that entry is changed accordingly. [#11542](https://github.com/JabRef/jabref/pull/11542)

src/main/java/org/jabref/gui/openoffice/OpenOfficePanel.java

@@ -618,12 +618,17 @@ private boolean checkThatEntriesHaveKeys(List<BibEntry> entries) {
     }
 
     private ContextMenu createSettingsPopup() {
-        OpenOfficePreferences openOfficePreferences = preferencesService.getOpenOfficePreferences();
 
         ContextMenu contextMenu = new ContextMenu();
 
+        if (currentStyle instanceof JStyle) {
+            addAlwaysCitedOnPagesTextOption(contextMenu);
+        }
+
+        OpenOfficePreferences openOfficePreferences = preferencesService.getOpenOfficePreferences();
+
         CheckMenuItem autoSync = new CheckMenuItem(Localization.lang("Automatically sync bibliography when inserting citations"));
-        autoSync.selectedProperty().set(preferencesService.getOpenOfficePreferences().getSyncWhenCiting());
+        autoSync.selectedProperty().set(openOfficePreferences.getSyncWhenCiting());
 
         ToggleGroup toggleGroup = new ToggleGroup();
         RadioMenuItem useActiveBase = new RadioMenuItem(Localization.lang("Look up BibTeX entries in the active tab only"));
@@ -657,4 +662,15 @@ private ContextMenu createSettingsPopup() {
 
         return contextMenu;
     }
+
+    private void addAlwaysCitedOnPagesTextOption(ContextMenu contextMenu) {
+        OpenOfficePreferences openOfficePreferences = preferencesService.getOpenOfficePreferences();
+
+        CheckMenuItem alwaysAddCitedOnPagesText = new CheckMenuItem(Localization.lang("Automatically add Cited on pages"));
+
+        alwaysAddCitedOnPagesText.selectedProperty().set(openOfficePreferences.getAlwaysAddCitedOnPages());
+        alwaysAddCitedOnPagesText.setOnAction(e -> openOfficePreferences.setAlwaysAddCitedOnPages(alwaysAddCitedOnPagesText.isSelected()));
+
+        contextMenu.getItems().add(alwaysAddCitedOnPagesText);
+    }
 }

src/main/java/org/jabref/logic/openoffice/OpenOfficePreferences.java

@@ -31,19 +31,21 @@ public class OpenOfficePreferences {
     private final ObservableList<String> externalStyles;
     private final StringProperty currentJStyle;
     private final ObjectProperty<OOStyle> currentStyle;
+    private final BooleanProperty alwaysAddCitedOnPages;
 
     public OpenOfficePreferences(String executablePath,
                                  boolean useAllDatabases,
                                  boolean syncWhenCiting,
                                  List<String> externalStyles,
                                  String currentJStyle,
-                                 OOStyle currentStyle) {
+                                 OOStyle currentStyle, boolean alwaysAddCitedOnPages) {
         this.executablePath = new SimpleStringProperty(executablePath);
         this.useAllDatabases = new SimpleBooleanProperty(useAllDatabases);
         this.syncWhenCiting = new SimpleBooleanProperty(syncWhenCiting);
         this.externalStyles = FXCollections.observableArrayList(externalStyles);
         this.currentJStyle = new SimpleStringProperty(currentJStyle);
         this.currentStyle = new SimpleObjectProperty<>(currentStyle);
+        this.alwaysAddCitedOnPages = new SimpleBooleanProperty(alwaysAddCitedOnPages);
     }
 
     public void clearConnectionSettings() {
@@ -137,4 +139,16 @@ public ObjectProperty<OOStyle> currentStyleProperty() {
     public void setCurrentStyle(OOStyle style) {
         this.currentStyle.set(style);
     }
+
+    public boolean getAlwaysAddCitedOnPages() {
+        return this.alwaysAddCitedOnPages.get();
+    }
+
+    public BooleanProperty alwaysAddCitedOnPagesProperty() {
+        return this.alwaysAddCitedOnPages;
+    }
+
+    public void setAlwaysAddCitedOnPages(boolean alwaysAddCitedOnPages) {
+        this.alwaysAddCitedOnPages.set(alwaysAddCitedOnPages);
+    }
 }

src/main/java/org/jabref/preferences/JabRefPreferences.java

@@ -371,6 +371,7 @@ public class JabRefPreferences implements PreferencesService {
     public static final String OO_BIBLIOGRAPHY_STYLE_FILE = "ooBibliographyStyleFile";
     public static final String OO_EXTERNAL_STYLE_FILES = "ooExternalStyleFiles";
     public static final String OO_CURRENT_STYLE = "ooCurrentStyle";
+    public static final String OO_ALWAYS_ADD_CITED_ON_PAGES = "ooAlwaysAddCitedOnPages";
 
     // Special field preferences
     public static final String SPECIALFIELDSENABLED = "specialFieldsEnabled";
@@ -756,6 +757,7 @@ private JabRefPreferences() {
         }
 
         defaults.put(OO_SYNC_WHEN_CITING, Boolean.TRUE);
+        defaults.put(OO_ALWAYS_ADD_CITED_ON_PAGES, Boolean.FALSE);
         defaults.put(OO_SHOW_PANEL, Boolean.FALSE);
         defaults.put(OO_USE_ALL_OPEN_BASES, Boolean.TRUE);
         defaults.put(OO_BIBLIOGRAPHY_STYLE_FILE, StyleLoader.DEFAULT_AUTHORYEAR_STYLE_PATH);
@@ -1377,10 +1379,12 @@ public OpenOfficePreferences getOpenOfficePreferences() {
                 getBoolean(OO_SYNC_WHEN_CITING),
                 getStringList(OO_EXTERNAL_STYLE_FILES),
                 get(OO_BIBLIOGRAPHY_STYLE_FILE),
-                currentStyle);
+                currentStyle,
+                getBoolean(OO_ALWAYS_ADD_CITED_ON_PAGES));
 
         EasyBind.listen(openOfficePreferences.executablePathProperty(), (obs, oldValue, newValue) -> put(OO_EXECUTABLE_PATH, newValue));
         EasyBind.listen(openOfficePreferences.useAllDatabasesProperty(), (obs, oldValue, newValue) -> putBoolean(OO_USE_ALL_OPEN_BASES, newValue));
+        EasyBind.listen(openOfficePreferences.alwaysAddCitedOnPagesProperty(), (obs, oldValue, newValue) -> putBoolean(OO_ALWAYS_ADD_CITED_ON_PAGES, newValue));
         EasyBind.listen(openOfficePreferences.syncWhenCitingProperty(), (obs, oldValue, newValue) -> putBoolean(OO_SYNC_WHEN_CITING, newValue));
 
         openOfficePreferences.getExternalStyles().addListener((InvalidationListener) change ->

src/main/resources/l10n/JabRef_en.properties

@@ -1132,6 +1132,7 @@ Unable\ to\ reload\ style\ file=Unable to reload style file
 
 Problem\ during\ separating\ cite\ markers=Problem during separating cite markers
 
+Automatically\ add\ Cited\ on\ pages=Automatically add "Cited on pages..." at beginning of citation
 Automatically\ sync\ bibliography\ when\ inserting\ citations=Automatically sync bibliography when inserting citations
 Look\ up\ BibTeX\ entries\ in\ the\ active\ tab\ only=Look up BibTeX entries in the active tab only
 Look\ up\ BibTeX\ entries\ in\ all\ open\ libraries=Look up BibTeX entries in all open libraries