Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add abstract param layout formatter test #11713

Merged

Conversation

leaf-soba
Copy link
Contributor

  • add unit test and refactor AbstractParamLayoutFormatter.parseArgument
  • reason:
  1. origin parseArgument method use too many if-else to make it confusing.
  2. I want to refactor it but it don't have any unit test.
  • screenshot:
2024-09-07 15 29 16

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code currently does not meet JabRef's code guidelines.
We use OpenRewrite to ensure "modern" Java coding practices.
The issues found can be automatically fixed.
Please execute the gradle task rewriteRun, check the results, commit, and push.

You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "OpenRewrite".

rewrite the test method name
Copy link
Collaborator

@InAnYan InAnYan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great code! Now it's much easier to understand the algorithm of the parser

@Siedlerchr Siedlerchr added this pull request to the merge queue Sep 8, 2024
Merged via the queue into JabRef:main with commit 7965eaa Sep 8, 2024
22 checks passed
@leaf-soba leaf-soba deleted the add-AbstractParamLayoutFormatterTest branch September 11, 2024 02:06
leaf-soba added a commit to leaf-soba/jabref that referenced this pull request Sep 11, 2024
* Rename "Show 'Ai Chat' tab" to "Show tab 'AI Chat'"

solve JabRef#11708

* add unit test and refactor parseArgument

add unit test and refactor AbstractParamLayoutFormatter.parseArgument

* rewrite the test method name

rewrite the test method name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants