-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add abstract param layout formatter test #11713
Add abstract param layout formatter test #11713
Conversation
add unit test and refactor AbstractParamLayoutFormatter.parseArgument
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code currently does not meet JabRef's code guidelines.
We use OpenRewrite to ensure "modern" Java coding practices.
The issues found can be automatically fixed.
Please execute the gradle task rewriteRun
, check the results, commit, and push.
You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "OpenRewrite".
rewrite the test method name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great code! Now it's much easier to understand the algorithm of the parser
src/test/java/org/jabref/logic/layout/format/AbstractParamLayoutFormatterTest.java
Show resolved
Hide resolved
* Rename "Show 'Ai Chat' tab" to "Show tab 'AI Chat'" solve JabRef#11708 * add unit test and refactor parseArgument add unit test and refactor AbstractParamLayoutFormatter.parseArgument * rewrite the test method name rewrite the test method name
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)