Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dark mode for table #11591

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Fix dark mode for table #11591

merged 1 commit into from
Aug 6, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented Aug 6, 2024

Follow-up to #11579

Dark mode was not working. I tried to use very dark colors now:

image

More changes:

  • When hovering on a focused line, the text color changes (to indicate the hover activity - otherwise, there is no hovering feedback)
  • Cleanup Base.css and MainTable.css
  • introduce -jr-hover-text

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

- Use very dark colors
- Highlight searches
- Cleanup Base.css and MainTable.css
- introduce -jr-hover-text
@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 6, 2024
@koppor koppor requested a review from LoayGhreeb August 6, 2024 13:39
@koppor koppor enabled auto-merge August 6, 2024 13:39
@koppor
Copy link
Member Author

koppor commented Aug 6, 2024

Just for completeness, I played around to mark the search results using a darker color, but then without any search, the entry table colros changed. That looked not good

image

Copy link
Contributor

github-actions bot commented Aug 6, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor koppor added this pull request to the merge queue Aug 6, 2024
@Siedlerchr Siedlerchr removed this pull request from the merge queue due to a manual request Aug 6, 2024
@Siedlerchr
Copy link
Member

light theme was also modified?

@LoayGhreeb
Copy link
Collaborator

Just a minor issue I noticed, when no item is selected, hovering over the first item gives it a different style compared to hovering over other items.

@koppor
Copy link
Member Author

koppor commented Aug 6, 2024

light theme was also modified?

Yes. Cleanup after yesterday's quick fix #11579

@koppor
Copy link
Member Author

koppor commented Aug 6, 2024

Just a minor issue I noticed, when no item is selected, hovering over the first item gives it a different style compared to hovering over other items.

Hahaha. This is a brain teaser.

It seems this item is focused, but the JabRef focus CSS does not trigger.

#FutureWork

@koppor koppor added this pull request to the merge queue Aug 6, 2024
Merged via the queue into main with commit 95a81e8 Aug 6, 2024
23 checks passed
@koppor koppor deleted the fix-dark-mode branch August 6, 2024 15:20
@koppor koppor mentioned this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants