Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to use koppor/gradle-modules-plugin "release" (made in fork) #11517

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented Jul 19, 2024

JitPack has issues. https://status.jitpack.io/

A problem occurred configuring root project 'JabRef'.
> Could not resolve all artifacts for configuration ':classpath'.
   > Could not resolve com.github.koppor.gradle-modules-plugin:gradle-modules-plugin:jitpack-SNAPSHOT.
     Required by:
         project : > com.github.koppor:gradle-modules-plugin:jitpack-SNAPSHOT:d68df40569-1
      > Could not resolve com.github.koppor.gradle-modules-plugin:gradle-modules-plugin:jitpack-SNAPSHOT.
         > Could not get resource 'https://jitpack.io/com/github/koppor/gradle-modules-plugin/gradle-modules-plugin/jitpack-SNAPSHOT/gradle-modules-plugin-jitpack-d68df40569-1.pom'.
            > Could not HEAD 'https://jitpack.io/com/github/koppor/gradle-modules-plugin/gradle-modules-plugin/jitpack-SNAPSHOT/gradle-modules-plugin-jitpack-d68df40569-1.pom'.
               > Read timed out
> There are 6 more failures with identical causes.

This should be "fixed" by pinning the plugin to a concrete version.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Copy link
Contributor

github-actions bot commented Jul 19, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr
Copy link
Member

We should get this fixed either in the original or submit your plugin to gradle repo or maven central. Jitpack is unreliable.

@Siedlerchr Siedlerchr enabled auto-merge July 19, 2024 14:08
@Siedlerchr Siedlerchr added this pull request to the merge queue Jul 19, 2024
Merged via the queue into main with commit a64bb07 Jul 19, 2024
25 of 26 checks passed
@Siedlerchr Siedlerchr deleted the use-jitpack-fork-release branch July 19, 2024 14:17
Siedlerchr added a commit that referenced this pull request Jul 24, 2024
* upstream/main:
  Bump gittools/actions from 1.2.0 to 2.0.0 (#11529)
  Bump src/main/resources/csl-styles from `fd6cb3e` to `bf2926b` (#11528)
  Bump org.openrewrite.rewrite from 6.16.3 to 6.16.4 (#11527)
  Bump org.apache.commons:commons-lang3 from 3.14.0 to 3.15.0 (#11525)
  Bump org.jspecify:jspecify from 0.3.0 to 1.0.0 (#11523)
  Bump com.github.andygoossens.modernizer from 1.9.2 to 1.9.3 (#11524)
  Always show star for local unsaved library (#11519)
  Update to javafx 22.02 (#11518)
  Try to use "release" (made in fork) (#11517)
  Fix NPE when saving preferences (#11515)
  New translations jabref_en.properties (Portuguese, Brazilian) (#11516)
Siedlerchr added a commit to LoayGhreeb/jabref that referenced this pull request Jul 24, 2024
…mance

* upstream/main:
  Bump gittools/actions from 1.2.0 to 2.0.0 (JabRef#11529)
  Bump src/main/resources/csl-styles from `fd6cb3e` to `bf2926b` (JabRef#11528)
  Bump org.openrewrite.rewrite from 6.16.3 to 6.16.4 (JabRef#11527)
  Bump org.apache.commons:commons-lang3 from 3.14.0 to 3.15.0 (JabRef#11525)
  Bump org.jspecify:jspecify from 0.3.0 to 1.0.0 (JabRef#11523)
  Bump com.github.andygoossens.modernizer from 1.9.2 to 1.9.3 (JabRef#11524)
  Always show star for local unsaved library (JabRef#11519)
  Update to javafx 22.02 (JabRef#11518)
  Try to use "release" (made in fork) (JabRef#11517)
  Fix NPE when saving preferences (JabRef#11515)
  New translations jabref_en.properties (Portuguese, Brazilian) (JabRef#11516)
  Add OpenAI privacy policy (JabRef#11511)
  import PMID field in Pubmed (JabRef#11513)
  New Crowdin updates (JabRef#11514)
michaellass added a commit to michaellass/AUR that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants