Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detection of soffice.exe #11478

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Fix detection of soffice.exe #11478

merged 5 commits into from
Jul 10, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented Jul 10, 2024

JabRef could not detect soffice.exe on my machine. I fixed it.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

}
})
// On Windows, the executable is nested in subdirectory "program"
.map(dir -> dir.resolve("program"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a check for Windows there? Not sure under linux (need to check on mac later this evening but there it seems to work out of the box)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, I was sure, it was called only at the Windos case

@@ -11,7 +11,7 @@

public class OpenOfficePreferences {

public static final String DEFAULT_WIN_EXEC_PATH = "C:\\Program Files\\LibreOffice 5\\program";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah guess they changed this at some point in time

Copy link
Contributor

github-actions bot commented Jul 10, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@calixtus calixtus changed the title Fix dection of soffice.exe Fix detection of soffice.exe Jul 10, 2024
@calixtus
Copy link
Member

works with windows 10 and my laptop distro (arch) out of the box.

@calixtus calixtus added this pull request to the merge queue Jul 10, 2024
Merged via the queue into main with commit e874c67 Jul 10, 2024
21 checks passed
@calixtus calixtus deleted the fix-oo-installation-path branch July 10, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants