-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix detection of soffice.exe #11478
Fix detection of soffice.exe #11478
Conversation
} | ||
}) | ||
// On Windows, the executable is nested in subdirectory "program" | ||
.map(dir -> dir.resolve("program")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a check for Windows there? Not sure under linux (need to check on mac later this evening but there it seems to work out of the box)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Damn, I was sure, it was called only at the Windos case
@@ -11,7 +11,7 @@ | |||
|
|||
public class OpenOfficePreferences { | |||
|
|||
public static final String DEFAULT_WIN_EXEC_PATH = "C:\\Program Files\\LibreOffice 5\\program"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah guess they changed this at some point in time
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
works with windows 10 and my laptop distro (arch) out of the box. |
JabRef could not detect
soffice.exe
on my machine. I fixed it.Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)