-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented "Current selection" group option #11455
Conversation
Added new option to the "Group Options" in the GroupDialog to allow the creation of a group that contains the currently selected entries. If there are no entries selected, this option is disabled. If there is more than one entry selected, this option is selected by default.
Added information on *Group by Current Selection*, featured added by JabRef/jabref#11455
Fixes failed unit test (keyValueShouldBeEqualForEnglishPropertiesMessages) and style test ( '(' is preceded with whitespace.)
I think, the group dialog for adding and editing groups should be the same. The current proposal also shows "Current selection" when editing a group: See https://docs.jabref.org/finding-sorting-and-cleaning-entries/groups#types-of-groups for the semantics of the different radio buttons. Maybe, we do not overoptimize too much and just add the selected entries to a group if "Explicit Selection" was chosen. I think the seldom case of unassignment can be easily done by a user. (I thought, there was an issue regarding unassignment via drag and drop at https://github.com/JabRef/jabref/issues?q=sort%3Aupdated-desc+is%3Aissue+is%3Aopen+label%3Agroups, but I did not find it) This solution contradicts the intention of groups.
|
@m-peeler Please merge |
Co-authored-by: Oliver Kopp <[email protected]>
@m-peeler Please see the failing test. Longer story: We made a release inbetween. Thus, your change will go into a next release. Therefore the test "CHANGELOG.md - only unreleased touched" was red. |
Yes! Was writing a comment but had to run off somewhere. I’ve just made a
second pull request with this feature and a create-on-right-click one that
should pass this test?
…On Tue, Jul 9, 2024 at 6:57 PM Oliver Kopp ***@***.***> wrote:
@m-peeler <https://github.com/m-peeler> Please see the failing test.
Longer story: We made a release inbetween. Thus, your change will go into a
next release. Therefore the test "CHANGELOG.md - only unreleased touched"
was red.
—
Reply to this email directly, view it on GitHub
<#11455 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2UZFFBI4KEK3WWWEPFHYA3ZLRTFRAVCNFSM6AAAAABKNNMHZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJYHA3TGMBRGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Then, I will close this PR - and we will concentrate on #11476. |
* Updated Groups documentation to reflect #11455 Added information on *Group by Current Selection*, feature added by JabRef/jabref#11455 * Fix Lint and add to types of groups --------- Co-authored-by: ThiloteE <[email protected]>
Added new option to the "Group Options" in the GroupDialog to allow the creation of a group that contains the currently selected entries. If there are no entries selected, this option is disabled. If there is more than one entry selected, this option is selected by default.
Closes #11449.
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)