Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expert mode for shared database connection #11303

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Add expert mode for shared database connection #11303

merged 4 commits into from
Jun 17, 2024

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented May 19, 2024

allows entering a custom jdbc url

Add lib for socket connection factory
https://jdbc.postgresql.org/documentation/use/#unix-sockets

Simply add ?socketFactory=org.newsclub.net.unix.AFUNIXSocketFactory$FactoryArg&socketFactoryArg=[path-to-the-unix-socket] to the connection URL.

Fixes https://github.com/JabRef/jabref-issue-melting-pot/issues/433
Fixes https://discourse.jabref.org/t/unix-socket-postgresql/4317/

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

allows entering a custom jdbc url

Add lib for socket connection factory
* upstream/main:
  Update latex citations status in JavaFx thread (#11302)
  Remove EnglishStemAnalyzer and use EnglishAnalyzer (#11301)
  Fix comment (#11299)
  Try gradle build speedup (#11300)
  Remove obsolete step (#11295)
  Bump com.fasterxml.jackson.dataformat:jackson-dataformat-yaml (#11290)
  Remove outdated pdf indexed files from Lucene index (#11293)
  Bump src/main/resources/csl-styles from `5338902` to `434df0a` (#11292)
  Bump org.mockito:mockito-core from 5.11.0 to 5.12.0 (#11291)
  Bump com.fasterxml.jackson.datatype:jackson-datatype-jsr310 (#11289)
  Bump com.dlsc.gemsfx:gemsfx from 2.12.0 to 2.16.0 (#11287)
  Bump org.openrewrite.recipe:rewrite-recipe-bom from 2.9.0 to 2.11.0 (#11288)
  Introduce formatter to remove word-enclosing braces (#11253)
  Try parallel tests (#9797)
  Store preview divider pos in entry editor (#11285)
Copy link
Contributor

github-actions bot commented May 19, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jun 14, 2024
@Siedlerchr Siedlerchr enabled auto-merge June 14, 2024 19:37
@Siedlerchr
Copy link
Member Author

I did not get any feedback from the guy and could not really test it myself with the socket stuff. Nonetheless I would like to have this integrated. In case anyone wants to use it

@Siedlerchr Siedlerchr added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit 77c5188 Jun 17, 2024
26 of 27 checks passed
@Siedlerchr Siedlerchr deleted the addcustomjdbc branch June 17, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants