-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix drag and dropping entries not always working #11255
Conversation
a24c994
to
a20def0
Compare
Please don't squash-and-merge as this pull request fixes 2 issues. |
codewise already looks good, will test it later |
Tested, works fine! Thanks! |
Awesome, do you think we can somehow add unit tests for the drag and drop logic? I'm out of ideas. |
Hm, would probably need a GUI test for the drag and drop stuff... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit tests for dnd would probably be much more effort. For now I think its enough to have it manually tested once.
As soon as the typos are fixed, squash is probably better anyway to avoid those typo commits in the main branch.
Fixing two closely related issues in one pr is not a problem imho.
@calixtus I think having the two commits separated is better because it leads to a cleaner history and would be easier to debug later in case of a regression. Plus it's possible to merge the typo fix commits into one of the exciting commits. It's very easy to do with IntelliJ. |
Go ahead. |
36b18e1
to
6aef455
Compare
- It doesn't work if the destination library has no group structure; "All entries" is the only group.
6aef455
to
9f259c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. High quality code, like always from you. Thanks!
Fix #11254
Fix #11160
It doesn't work if the destination library has no group structure; "All entries" is the only group.
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)