Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drag and dropping entries not always working #11255

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

HoussemNasri
Copy link
Member

@HoussemNasri HoussemNasri commented Apr 28, 2024

Fix #11254
Fix #11160

It doesn't work if the destination library has no group structure; "All entries" is the only group.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@HoussemNasri HoussemNasri force-pushed the fix-entry-drag-drop branch 2 times, most recently from a24c994 to a20def0 Compare April 28, 2024 19:04
@HoussemNasri
Copy link
Member Author

Please don't squash-and-merge as this pull request fixes 2 issues.

@Siedlerchr
Copy link
Member

codewise already looks good, will test it later

Siedlerchr
Siedlerchr previously approved these changes Apr 29, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Apr 29, 2024
@Siedlerchr
Copy link
Member

Tested, works fine! Thanks!

@HoussemNasri
Copy link
Member Author

Awesome, do you think we can somehow add unit tests for the drag and drop logic? I'm out of ideas.

@Siedlerchr
Copy link
Member

Hm, would probably need a GUI test for the drag and drop stuff...

calixtus
calixtus previously approved these changes Apr 29, 2024
Copy link
Member

@calixtus calixtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests for dnd would probably be much more effort. For now I think its enough to have it manually tested once.
As soon as the typos are fixed, squash is probably better anyway to avoid those typo commits in the main branch.
Fixing two closely related issues in one pr is not a problem imho.

@HoussemNasri
Copy link
Member Author

@calixtus I think having the two commits separated is better because it leads to a cleaner history and would be easier to debug later in case of a regression. Plus it's possible to merge the typo fix commits into one of the exciting commits. It's very easy to do with IntelliJ.

@calixtus
Copy link
Member

Go ahead.

@HoussemNasri HoussemNasri dismissed stale reviews from calixtus and Siedlerchr via 6cf524a April 30, 2024 11:26
- It doesn't work if the destination library has no group structure; "All entries" is the only group.
Copy link
Member

@calixtus calixtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. High quality code, like always from you. Thanks!

@Siedlerchr Siedlerchr merged commit 0046e98 into JabRef:main Apr 30, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
3 participants