Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable JDK22 build #11059

Merged
merged 8 commits into from
Mar 21, 2024
Merged

Enable JDK22 build #11059

merged 8 commits into from
Mar 21, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented Mar 20, 2024

Follow-up to #11057 and #11058.

The EA workflow now builds using JDK22 features (using gradle 8.7-rc.3, which supports JDK22 for compilation)

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor
Copy link
Member Author

koppor commented Mar 20, 2024

Blocked by gradle/gradle#16791

tasks.register("generateJournalListMV", JavaExec) {
    group = "JabRef"
    description = "Converts the comma-separated journal abbreviation file to a H2 MVStore"
    classpath = sourceSets.main.runtimeClasspath
    mainClass = "org.jabref.cli.JournalListMvGenerator"
    onlyIf {
        !file("build/resources/main/journals/journal-list.mv").exists()
    }
}
java.lang.UnsupportedClassVersionError: org/jabref/cli/JournalListMvGenerator has been compiled by a more recent version of the Java Runtime (class file version 66.0), this version of the Java Runtime only recognizes class file versions up to 65.0
Successfully started process 'command '/opt/hostedtoolcache/Java_Liberica_jdk/21.0.2-14/x64/bin/java''

@koppor koppor added status: depends-on-external A bug or issue that depends on an update of an external library dev: build-system labels Mar 20, 2024
@koppor koppor closed this Mar 20, 2024
@koppor koppor reopened this Mar 20, 2024
@koppor
Copy link
Member Author

koppor commented Mar 20, 2024

For jpackage, we have

Caused by: java.lang.module.InvalidModuleDescriptorException: Unsupported major.minor version 66.0

@koppor koppor added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers and removed status: depends-on-external A bug or issue that depends on an update of an external library labels Mar 20, 2024
@koppor koppor marked this pull request as ready for review March 20, 2024 11:43
@koppor koppor mentioned this pull request Mar 20, 2024
7 tasks
@koppor
Copy link
Member Author

koppor commented Mar 20, 2024

Should work now. Norma build: JDK21, EA with JDK22

@Siedlerchr Siedlerchr enabled auto-merge March 21, 2024 22:37
@Siedlerchr Siedlerchr added this pull request to the merge queue Mar 21, 2024
Copy link
Contributor

github-actions bot commented Mar 21, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

Merged via the queue into main with commit e85f5b6 Mar 21, 2024
29 of 30 checks passed
@Siedlerchr Siedlerchr deleted the update-gradle-to-rc branch March 21, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev: build-system status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants