Add group dialog directory structure option #10991
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add radio button ´Directory Structure´ in the add group form - When selected you can browse and upload a local directory - A group with the same name as the local directory will be aotumatically created. - Add a validator to ensure that the browsed path is a directory.
- 4 new tests that validate the correcteness of "dirGroupFilePathValidator" - Put an entry in CHANGELOG.md for our added functionality.
Test: findMissingLocalizationKeys() FAILED Added: Please\ provide\ a\ valid\ directory=Please provide a valid directory To: JabRef_en.properties
koppor
reviewed
Mar 14, 2024
|
I tried to enter a directory without "Browse". Cannot press "OK":
|
|
If I add a directory, it is not reflected in the tree automatically:
|
|
A call to "Add subgroup" is possible. That is good.
It is bad, however, that other groups than a directory group can be created. Proposal: Replace "Add subgroup" menu item by "Create sub directory". |
|
Restart of JabRef does not show any sub groups - even though there are sub directories:
|
|
Not sure, if it is related - but there is an aux parser exception at the beginning |
|
@eggestig and @AntonSederlin May we ask whether you intend to continue on this? 😅 |
|
Hi @koppor! I have not been recieving any notifications for all of your updates it seems, I apologize for the late reply. We would have loved to continue, but unfortunately our course has ended and I do believe most of us are quite busy with other courses right now. So we will unfortunately not be continuing (I would possibly be able to continue if there was a guide or some hints towards how to create subgroup(s) without needing a dialogue window). Also for clarification, we are aware that sub groups are not created (only the top-level group is). We struggled with finding a way of calling the creation of multiple groups with group dialogue window*, as mentioned in the pull request. So we decided we would push what we could make, which was the creation of the radiobutton For the future, if someone plans on continuing, all that is left is to figure out how to create subgroups from that single dialogue window, after which it is easy to simply create the subgroups with the selected root directory as the hierarchy recursively. Again, I apologize for the late reply! |
|
@eggestig Thank you for the update! In future, I will make more use of the mention feature to ensure that contributors are notified!
I think, one needs to implement a I will close the PR and hope some other group will work on this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial and partial solution to issue #10930.
Given a directory we want to mirror the hierarchy and automatically create groups and subgroups accordingly.
To partially address this issue, we added a new radio button in the "add group dialog" that allows a user to browse a local directory, import it, and then automatically create a group with the same name, see screenshot below.
As of now:
If you import the directory Related_Work_Collection/Quantum_Computing, only the group Quantum_Computing will be created automatically as this is the selected directory.
Future work:
If you import the directory Related_Work_Collection/Quantum_Computing, also recursively add every potential child directory inside Quantum_Computing as subgroups.
Problems:
As we tried to tackle this issue we struggled with creating sub groups recursively as this appears to require an even deeper understanding of the project architecture and thus decided to leave this to future work.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)