-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: abstract field loses markdown formatter after resetting default preview style #10942
Conversation
There is also a related issue for the same PR, when running the program from IntelliJ pasting HTML code into fields works fine but when running the latest development release, it causes an exception:
|
Thanks for the hint, this looks like some modularity issue (happens whe not all libraries are modularized). I'll take a look at it. (You can build executables of JabRef also manually using ./gradlew jlink or ./gradlew jpackage) I'll prepare a fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch.
Re-thinking, I think, MARKDOWN
should be removed from abstract
and added to review
@LoayGhreeb Could you please do more (as suggested at #10942 (review))? Meaning: No Markdown support for abstract, but for review! |
@koppor I'm not sure what the benefit of supporting |
Changes are fine, thank you!
Ah, this reminds me, that we silently change the field Thus, adding |
After PR #10896, the abstract field now supports markdown.
If I try to reset the default preview style from the preferences, the abstract loses the markdown formatter.
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)