Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: abstract field loses markdown formatter after resetting default preview style #10942

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

LoayGhreeb
Copy link
Collaborator

After PR #10896, the abstract field now supports markdown.
If I try to reset the default preview style from the preferences, the abstract loses the markdown formatter.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@LoayGhreeb
Copy link
Collaborator Author

There is also a related issue for the same PR, when running the program from IntelliJ pasting HTML code into fields works fine but when running the latest development release, it causes an exception:

java.lang.IllegalAccessError: class com.vladsch.flexmark.html2md.converter.FlexmarkHtmlConverter (in module 
org.jabref.merged.module) cannot access class org.jsoup.Jsoup (in module org.jsoup) because module org.jabref.merged.module 
does not read module org.jsoup

@Siedlerchr
Copy link
Member

Thanks for the hint, this looks like some modularity issue (happens whe not all libraries are modularized). I'll take a look at it. (You can build executables of JabRef also manually using ./gradlew jlink or ./gradlew jpackage)

I'll prepare a fix

@Siedlerchr
Copy link
Member

#10943

Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

Re-thinking, I think, MARKDOWN should be removed from abstract and added to review

@LoayGhreeb LoayGhreeb requested a review from koppor February 28, 2024 21:43
@koppor
Copy link
Member

koppor commented Feb 28, 2024

@LoayGhreeb Could you please do more (as suggested at #10942 (review))? Meaning: No Markdown support for abstract, but for review!

@LoayGhreeb
Copy link
Collaborator Author

@koppor I'm not sure what the benefit of supporting MARKDOWN for the review field is, since it's not visible in the preview.
Are these the needed changes?

@koppor
Copy link
Member

koppor commented Feb 29, 2024

Are these the needed changes?

Changes are fine, thank you!

@koppor I'm not sure what the benefit of supporting MARKDOWN for the review field is, since it's not visible in the preview.

Ah, this reminds me, that we silently change the field review to comment 🙈. Refs #10370. This needs to be changed soon.

Thus, adding MARKDOWN to review is not that senseful, but maybe, we bring back the field and then it has the "right" properties.

@koppor koppor added this pull request to the merge queue Feb 29, 2024
Merged via the queue into JabRef:main with commit 597828b Feb 29, 2024
20 checks passed
@LoayGhreeb LoayGhreeb deleted the fix-abstract branch February 29, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants