Convert the "Custom API key" list to a table [#10926]

[AbdAlRahmanGad]

Fixes #10926

demo.mov

The only difference from the previous implementation that the user can edit the "key" even if the "use custom key" is not checked. I still didn't find an efficient way to solve it so I will wait for your feedback.

Mandatory checks

• Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
• Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

[calixtus]

Hi, thanks for your interest in JabRef and OpenSource. I like the change to the ui, yet i have a comment about your implementation. I recommend the book Effective Java by Josh Bloch. Here is a summary that I like to use myself: https://github.com/HugoMatilla/Effective-JAVA-Summary

[AbdAlRahmanGad]

@calixtus Hi, thanks for the feedback. I will check the resources you provided and modify the code.

[Siedlerchr]

You could disable the field if it's not selected (e.g binding)
And regarding the exception handling, better is to use Validation

[calixtus]

Shouldn't the keys be hidden behind asterisks
@JabRef/developers ?

[Siedlerchr]

Yeah, maybe some kind of PasswordField or something similar can be used

[koppor]

How can I change a key? I tried to click and double click (Windows 11), but nothing happened.

The checkbox on the right should be enabled only if there is a custom key.

[AbdAlRahmanGad]

@koppor I made that you can't enter a key unless you enable the check. 0914142

Should I make it the opposite: if you enter a key then the checkbox will be enabled?

[koppor]

Yeah, the opposite is great. The checkmark should automatically be set then.

Maybe no disablement of the checkbox. There seem to be two kinds of user flows 🤣🤣

On dialog close, the key should only be enabled if non empty.

[AbdAlRahmanGad]

@koppor Just to make sure I understood right.

• If a user enter a key the checkbox is enabled automatically
• if the key is empty the checkbox is disabled automatically

Also, can the user change the checkbox manually?

[koppor]

@koppor Just to make sure I understood right.

You came up with an even better solution!

Go for it!

[calixtus]

Until now it was also possible to store custom keys, even if they are not used. Would be a regression if we automatically use the key if stored or remove it, when unchecked...

[AbdAlRahmanGad]

@calixtus Sorry, I saw your comment after I commited.
So, should I make the user able to edit both manually?

[calixtus]

There are use cases one would want to keep the custom API stored without using it, maybe just to test something maybe.

[AbdAlRahmanGad]

I think the code is ready for review now.

[Siedlerchr]

From my side lgtm, just one minor addition: Can you add the note that is at the tab Citation key patterns, here as well?