Fix "Changing owner name crashes the application" #10932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
reviewed
Feb 27, 2024
| internalPreferences = null; | ||
|
|
||
| // this propagates down to filePreferences | ||
| getInternalPreferences().getUserAndHostProperty().setValue(newValue); |
There was a problem hiding this comment.
I wonder why this property is both in the owner preferences and the internal prefs. This looks like it should be only in one place
There was a problem hiding this comment.
Filed follow-up issue https://github.com/JabRef/jabref-issue-melting-pot/issues/362
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
|
As a quick fix okay, but we should really merge the preferences |
Siedlerchr
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10924
At #9910 I did not properly use our subscription system.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)