Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BibTeX 'Title' to MS Office 'Publicationtitle' field #10864

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

dhrax21
Copy link
Contributor

@dhrax21 dhrax21 commented Feb 7, 2024

Fixes #10807

" if ("Art".equals(msBibType) || "Misc".equals(msBibType)) {
 result.publicationTitle = entry.getFieldLatexFree(StandardField.TITLE).orElse(null);

}"

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date?

@calixtus calixtus changed the title #10807 BibTeX 'Title' to MS Office 'Publicationtitle' field BibTeX 'Title' to MS Office 'Publicationtitle' field Feb 7, 2024
@Siedlerchr
Copy link
Member

Thanks, looks good so far! Can you please add a test for this and a changelog?

Basically, you create a minimal bib file and an xml file wiht the same name that contains the exporterd content.
MSBibExportFormatFilesTest i

@dhrax21
Copy link
Contributor Author

dhrax21 commented Feb 9, 2024

Yeah! Thanks for replying , so can you explain me like where do I need to put the changelog(which file) and I'm not getting "ou create a minimal bib file and an xml file with the same name that contains the exported content.
MSBibExportFormatFilesTest i" like do I need to create a separate file

@Siedlerchr
Copy link
Member

For changelog: Edit the changelog.md file

For the test files, the name has to start with MSBibXml
https://github.com/JabRef/jabref/tree/main/src/test/resources/org/jabref/logic/exporter

So you create a minimal bib file with an entry like in the issue. Then export it to Office.xml and copy both files in the folder (rename them to the format)

@dhrax21
Copy link
Contributor Author

dhrax21 commented Feb 9, 2024

Hey I have pushed file changes but some of the unit tests are failing , I'm not able to get references

@Siedlerchr
Copy link
Member

The unit test failure looks odd, but it can fail occasionnaly, and is not related to your changes.

@Siedlerchr Siedlerchr enabled auto-merge February 9, 2024 16:12
@Siedlerchr Siedlerchr added this pull request to the merge queue Feb 9, 2024
Merged via the queue into JabRef:main with commit e71ad29 Feb 9, 2024
20 checks passed
@dhrax21
Copy link
Contributor Author

dhrax21 commented Feb 10, 2024

Hi Thanks for merging the pr , but why I'm not given any badge for contribution , just wanna know!

@Siedlerchr
Copy link
Member

No idea. Ask github

Siedlerchr added a commit to rdsingh13/jabref that referenced this pull request Feb 11, 2024
* upstream/main: (68 commits)
  BibTeX 'Title' to MS Office 'Publicationtitle' field (JabRef#10864)
  Introduce BibliographyConsistencyCheckResultTxtWriter (JabRef#10847)
  Upgrade gradle-build-action to actions/setup-gradle (JabRef#10866)
  Bump org.apache.lucene:lucene-core from 9.9.1 to 9.9.2 (JabRef#10860)
  Bump org.junit.jupiter:junit-jupiter from 5.10.1 to 5.10.2 (JabRef#10863)
  Bump org.apache.lucene:lucene-highlighter from 9.9.1 to 9.9.2 (JabRef#10861)
  Bump org.tinylog:tinylog-api from 2.6.2 to 2.7.0 (JabRef#10862)
  Bump org.apache.lucene:lucene-queryparser from 9.9.1 to 9.9.2 (JabRef#10859)
  Bump gradle/wrapper-validation-action from 1 to 2 (JabRef#10858)
  Bump codecov/codecov-action from 3 to 4 (JabRef#10857)
  Bump peter-evans/create-pull-request from 5 to 6 (JabRef#10856)
  Update Gradle Wrapper from 8.5 to 8.6. (JabRef#10854)
  Enable auto merge of gradle wrapper update
  Jump to entry from cli (JabRef#10578)
  Fix closing of JabRef in case of issues with index writer (JabRef#10840)
  Update deployment-arm64.yml
  use nio path
  fix submodules
  Fix secrents presence chcek
  Update deployment-arm64.yml
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants