Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed fulltext fetcher button invisible #10819

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Fixed fulltext fetcher button invisible #10819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8f163e
fixed issue 10425
AnandChandrakar Jan 23, 2024
f37cbbd
fixed issue 10425
AnandChandrakar Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv

### Fixed

- We fixed an issue where the fulltext search button in entry editor used to disappear on click till the search is completed. [#10425](https://github.com/JabRef/jabref/issues/10425)
- We fixed an issue where attempting to cancel the importing/generation of an entry from id is ignored. [#10508](https://github.com/JabRef/jabref/issues/10508)
- We fixed an issue where the preview panel showing the wrong entry (an entry that is not selected in the entry table). [#9172](https://github.com/JabRef/jabref/issues/9172)
- The last page of a PDF is now indexed by the full text search. [#10193](https://github.com/JabRef/jabref/issues/10193)
Expand Down
5 changes: 2 additions & 3 deletions src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditor.fxml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,8 @@
<Button onAction="#fetchFulltext" styleClass="icon-button">
<graphic>
<StackPane>
<JabRefIconView fx:id="fulltextFetcher" glyph="FETCH_FULLTEXT" visible="false"/>
<ProgressIndicator maxHeight="12.0" maxWidth="12.0"
visible="${controller.viewModel.fulltextLookupInProgress}"/>
<JabRefIconView fx:id="fulltextFetcher" glyph="FETCH_FULLTEXT"/>
<ProgressIndicator fx:id="progressIndicator" maxHeight="12.0" maxWidth="12.0"/>
</StackPane>
</graphic>
<tooltip>
Expand Down
3 changes: 3 additions & 0 deletions src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
import javafx.scene.control.ListView;
import javafx.scene.control.OverrunStyle;
import javafx.scene.control.ProgressBar;
import javafx.scene.control.ProgressIndicator;
import javafx.scene.control.SelectionMode;
import javafx.scene.control.SeparatorMenuItem;
import javafx.scene.control.Tooltip;
Expand Down Expand Up @@ -67,6 +68,7 @@ public class LinkedFilesEditor extends HBox implements FieldEditorFX {

@FXML private ListView<LinkedFileViewModel> listView;
@FXML private JabRefIconView fulltextFetcher;
@FXML private ProgressIndicator progressIndicator;

private final Field field;
private final BibDatabaseContext databaseContext;
Expand Down Expand Up @@ -127,6 +129,7 @@ private void initialize() {
listView.getSelectionModel().setSelectionMode(SelectionMode.MULTIPLE);

fulltextFetcher.visibleProperty().bind(viewModel.fulltextLookupInProgressProperty().not());
progressIndicator.visibleProperty().bind(viewModel.fulltextLookupInProgressProperty());

setUpKeyBindings();
}
Expand Down
Loading