Enhance issue #5507 Add switch button and pages layout for fetchers/websearch #10595
Conversation
* improve medline * checksstyle * move * fix checkstyle --------- Co-authored-by: Oliver Kopp <[email protected]>
|
|
ThiloteE
changed the title
ThiloteE
changed the title
| private final XMLInputFactory xmlInputFactory; | ||
|
|
||
| public MedlineImporter() { | ||
| this.xmlInputFactory = XMLInputFactory.newInstance(); | ||
| // prevent xxe (https://rules.sonarsource.com/java/RSPEC-2755) | ||
| xmlInputFactory.setProperty(XMLConstants.ACCESS_EXTERNAL_SCHEMA, ""); | ||
| // required for reading Unicode characters such as ö | ||
| xmlInputFactory.setProperty(XMLInputFactory.IS_COALESCING, true); | ||
| // TODO: decide if necessary, if disabled MedlineImporterTestNbib fails | ||
| xmlInputFactory.setProperty(XMLInputFactory.IS_SUPPORTING_EXTERNAL_ENTITIES, true); | ||
| } |
There was a problem hiding this comment.
Sorry I got no idea, I didn't modify this part.
| Previous=Create property | ||
| Next=Create property | ||
| Page\:=Create property |
There was a problem hiding this comment.
I don't understand this? -- Did you modify the wrong file? JabRef_en.properties. See https://devdocs.jabref.org/code-howtos/localization.html for more information
There was a problem hiding this comment.
When I create a button name and page layout it will show error if I didn't do that.
| @@ -49,13 +50,16 @@ | |||
| import jakarta.inject.Inject; | |||
| import org.controlsfx.control.CheckListView; | |||
|
|
|||
| @SuppressWarnings("checkstyle:RegexpMultiline") | |||
There was a problem hiding this comment.
It changing automaticity. I didn't do anything on that.
|
Sorry about that. Cause the time limit that's what I can think and done. |
|
Hi @JunyuLuo123 , what's the status here? Are you planning to continue this PR? |
|
As the user obviously lost interest in this PR, i'm closing it for housekeeping. Feel free to open a new PR if you decide to continue your work. |
Enhances #5507
Add the switch button and pages layout.