Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add git support #10586
Add git support #10586
Changes from 51 commits
10a4779
2c25b5f
91a12f1
1126bc2
f3ae12e
c312817
7ffe7f1
905eda9
b104b99
bf33ca0
375e689
d3a8014
a1e8ca0
e4dd331
4c81e54
df3e4bb
298d86e
6109741
27b95bf
e935882
344775b
7d0b6db
f3313b1
6686905
a102257
a2a5a71
fdebffa
45cd433
35949a9
72c7532
c184846
6dfac3f
f4941a0
c2e5d74
a6682a0
b0351ab
dff72dd
bbf1829
a6021ea
6b8700f
cfdd3c8
f9abb2c
75bce3c
596275a
ce2e1d3
18a3373
4ebfd85
0379fad
ceab32c
873a5cc
bc0fd86
6b5d9e1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, all exceptions can be merged into one, because there is no "real" different behavior.
Please use notifications instead of dialogs. Reason: The flow of the user should not be disturbed while working with git.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not returning "false" if something goes wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not crash complete JabRef on an error.