Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Group Sorting Options #10492

Merged
merged 9 commits into from
Oct 20, 2023
Merged

Conversation

Preetish-T
Copy link
Contributor

@Preetish-T Preetish-T commented Oct 13, 2023

I have added an option to further sort subgroups on Z-A order, and also by ascending and descending number of subgroups. Currently only the option to sort from A-Z exists.

Fixes #10249

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.
    new PR

@ThiloteE
Copy link
Member

To ease organizational workflows I have linked the pull-request to the issue with syntax as described in https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

Linking a pull request to an issue using a keyword

You can link a pull request to an issue by using a supported keyword in the pull request's description or in a commit message. The pull request must be on the default branch.

  • close
  • closes
  • closed
  • fix
  • fixes
  • fixed
  • resolve
  • resolves
  • resolved

If you use a keyword to reference a pull request comment in another pull request, the pull requests will be linked. Merging the referencing pull request also closes the referenced pull request.

The syntax for closing keywords depends on whether the issue is in the same repository as the pull request.

@Siedlerchr
Copy link
Member

Please have a look a the failing tests and also https://devdocs.jabref.org/code-howtos/localization.html

@Preetish-T
Copy link
Contributor Author

Thanks for the feedback, the test cases should be passing now.

@calixtus calixtus added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 14, 2023
Siedlerchr
Siedlerchr previously approved these changes Oct 16, 2023
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codewise looks good to me

@Siedlerchr Siedlerchr removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 18, 2023
@Siedlerchr
Copy link
Member

Sorry, but sorting by number of sub groups does not make sense. Int the issue it was about the number of entries in the group.

What you did was sorting by number of sub groups. Please implement the sorting by number of entries in the group:
grafik

@Siedlerchr Siedlerchr added the status: changes required Pull requests that are not yet complete label Oct 18, 2023
@Preetish-T
Copy link
Contributor Author

Thanks for the feedback, I realise my mistake now. I believe the latest push should properly implement the sorting by entries options.

Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me and works!

@Siedlerchr Siedlerchr added this pull request to the merge queue Oct 20, 2023
Merged via the queue into JabRef:main with commit d13b570 Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: groups status: changes required Pull requests that are not yet complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: add more group sorting options
4 participants