Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .COMMENT instead of outdated .REVIEW #10478

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Use .COMMENT instead of outdated .REVIEW #10478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0594cb2
Use .COMMENT instead of outdated .REVIEW
koppor Oct 10, 2023
26d0026
Adapt tests of IsiImporter
koppor Oct 10, 2023
9f1f394
Update CHANGELOG.md
koppor Oct 10, 2023
7ec949f
Update CHANGELOG.md
koppor Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
- When searching for an identifier in the "Web search", the title of the search window is now "Identifier-based Web Search". [#10391](https://github.com/JabRef/jabref/pull/10391)
- The ampersand checker now skips verbatim fields (`file`, `url`, ...). [#10419](https://github.com/JabRef/jabref/pull/10419)
- If no existing document is selected for exporting "XMP annotated pdf" JabRef will now create a new PDF file with a sample text and the metadata. [#10102](https://github.com/JabRef/jabref/issues/10102)
- We modified the DOI cleanup to infer the DOI from an ArXiV ID if it's present. [10426](https://github.com/JabRef/jabref/issues/10426)
- We modified the DOI cleanup to infer the DOI from an ArXiV ID if it's present. [#10426](https://github.com/JabRef/jabref/issues/10426)
- The ISI importer uses the field `comment` for notes (instead of `review). [#10478](https://github.com/JabRef/jabref/pull/10478)

### Fixed

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/jabref/logic/importer/fileformat/IsiImporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ public boolean isRecognizedFormat(BufferedReader reader) throws IOException {
}

public static void processSubSup(Map<Field, String> map) {
Field[] subsup = {StandardField.TITLE, StandardField.ABSTRACT, StandardField.REVIEW, new UnknownField("notes")};
Field[] subsup = {StandardField.TITLE, StandardField.ABSTRACT, StandardField.COMMENT, new UnknownField("notes")};

for (Field aSubsup : subsup) {
if (map.containsKey(aSubsup)) {
Expand Down
8 changes: 4 additions & 4 deletions src/test/java/org/jabref/logic/importer/fileformat/IsiImporterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,9 @@ public void testProcessSubSup() {
IsiImporter.processSubSup(subs);
assertEquals("$_3$", subs.get(StandardField.ABSTRACT));

subs.put(StandardField.REVIEW, "/sub 31/");
subs.put(StandardField.COMMENT, "/sub 31/");
IsiImporter.processSubSup(subs);
assertEquals("$_{31}$", subs.get(StandardField.REVIEW));
assertEquals("$_{31}$", subs.get(StandardField.COMMENT));

subs.put(StandardField.TITLE, "/sup 3/");
IsiImporter.processSubSup(subs);
Expand All @@ -114,9 +114,9 @@ public void testProcessSubSup() {
IsiImporter.processSubSup(subs);
assertEquals("$^3$", subs.get(StandardField.ABSTRACT));

subs.put(StandardField.REVIEW, "/sup 31/");
subs.put(StandardField.COMMENT, "/sup 31/");
IsiImporter.processSubSup(subs);
assertEquals("$^{31}$", subs.get(StandardField.REVIEW));
assertEquals("$^{31}$", subs.get(StandardField.COMMENT));

subs.put(StandardField.TITLE, "/sub $Hello/");
IsiImporter.processSubSup(subs);
Expand Down