Update casing of "JabRef" #10345
Closed
Update casing of "JabRef" #10345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Lowercase "jabref" in scripts and binary names - Change vendor to JabRef e.V. - Case "mac-package-identifier" to "JabRef" - Group macos steps together
|
Maybe, this conflicts with #10340 ( |
|
The build of this PR is available at https://builds.jabref.org/pull/10345/merge. |
Siedlerchr
reviewed
Sep 7, 2023
| --mac-package-identifier Jabref \ | ||
| --mac-package-name JabRef \ | ||
| --mac-package-identifier JabRef \ | ||
| --mac-package-name "JabRef e.V." \ |
Siedlerchr
reviewed
Sep 7, 2023
.github/workflows/deployment.yml
Outdated
| @@ -283,26 +283,26 @@ jobs: | |||
| if: steps.checksecrets.outputs.secretspresent == 'YES' | |||
| id: gitversion | |||
| uses: gittools/actions/gitversion/[email protected] | |||
| - name: Get macOS binaries | |||
| - name: Get macos binaries | |||
There was a problem hiding this comment.
This is wrong! The casing of macOS is correct official
|
We should discuss implications first |
calixtus
previously approved these changes
Sep 7, 2023
|
We should keep the casing as is, this how it looks like in mac: |
|
We should distinguish
#FutureWork |
This was referenced Sep 8, 2023
This was referenced Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #10338.
We either need this fix - or add an explanation in the documentation how to "properly" check out the code to have IntelliJ working (one commit in #10322 does this).
Since I more want to have the guideline "intuitive", I would like to have this change in.
The installer file names and the startup scripts will be all-lowercase now. Which I kind of like. (
bin/jabrefinstead ofbin/JabRef)Update casing of "JabRef"
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)