-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exception when opening preferences #10294
Conversation
Your code currently does not meet JabRef's code guidelines. The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues. More information on code quality in JabRef is available at https://devdocs.jabref.org/getting-into-the-code/development-strategy.html. |
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
* upstream/main: Use OpenRewrite UseStringReplace (#10299) Add ReplaceStringBuilderWithString (#10302) Apply ShortenFullyQualifiedTypeReferences (#10301) Apply StaticMethodNotFinal (#10300) Apply exit early pattern (#10297) Avoid GH_TOKEN_UPDATE_GRADLE_WRAPPER at refresh-csl-subtrees Update snapcraft.yaml Fix exception when opening preferences (#10294) gnome-42-2204 use gnome 4.2 Use gnome Update base 22
* upstream/main: (737 commits) Use OpenRewrite UseStringReplace (#10299) Add ReplaceStringBuilderWithString (#10302) Apply ShortenFullyQualifiedTypeReferences (#10301) Apply StaticMethodNotFinal (#10300) Apply exit early pattern (#10297) Avoid GH_TOKEN_UPDATE_GRADLE_WRAPPER at refresh-csl-subtrees Update snapcraft.yaml Fix exception when opening preferences (#10294) gnome-42-2204 use gnome 4.2 Use gnome Update base 22 Add method for detecting journal abbrev delimiter (#10281) Update bug_report.yml Fix selection of table sort order (#10250) Fix mixup with YAML tags (#10287) More guards for upload (#10282) Reduced calls to Globals.prefs and Globals.entryTypesManager (#10177) Update jmh plugin (#10279) Add computer science to protected terms (#10222) ... # Conflicts: # build.gradle # src/main/java/module-info.java # src/main/java/org/jabref/cli/Launcher.java # src/main/java/org/jabref/preferences/JabRefPreferences.java # src/main/resources/tinylog.properties
…ustStore * upstream/main: (295 commits) Use OpenRewrite UseStringReplace (#10299) Add ReplaceStringBuilderWithString (#10302) Apply ShortenFullyQualifiedTypeReferences (#10301) Apply StaticMethodNotFinal (#10300) Apply exit early pattern (#10297) Avoid GH_TOKEN_UPDATE_GRADLE_WRAPPER at refresh-csl-subtrees Update snapcraft.yaml Fix exception when opening preferences (#10294) gnome-42-2204 use gnome 4.2 Use gnome Update base 22 Add method for detecting journal abbrev delimiter (#10281) Update bug_report.yml Fix selection of table sort order (#10250) Fix mixup with YAML tags (#10287) More guards for upload (#10282) Reduced calls to Globals.prefs and Globals.entryTypesManager (#10177) Update jmh plugin (#10279) Add computer science to protected terms (#10222) ...
I "forgot" to properly handly self-containedness at the exporters. This caused
The underlying issue is that concrete exporters are generated in the preferences. In future work, this should be solved. This PR "only" fixes that setting the preferences works again.
There is
SelfContainedSaveConfiguration
introduced analogous toSelfContainedSaveOrder
.Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)