Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix customImporterTabViewModel is duplicated when export of Preferences #10241

Merged
merged 6 commits into from
Aug 29, 2023

Conversation

papatekken
Copy link
Contributor

@papatekken papatekken commented Aug 29, 2023

After export/import/reset of Preferences, customerImporterTabViewModel, customerExporterTabViewModel and externalFileTypesTabViewModel are duplicated.

so in this change, viewModel is cleared before sync with preferencesService.

That will fix #10176

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@papatekken papatekken changed the title Fix when export of Preferences, customImporterTabViewModel is duplicated #10176 Fix when export of Preferences, customImporterTabViewModel is duplicated Aug 29, 2023
@papatekken papatekken changed the title Fix when export of Preferences, customImporterTabViewModel is duplicated Fix customImporterTabViewModel is duplicated when export of Preferences Aug 29, 2023
calixtus
calixtus previously approved these changes Aug 29, 2023
Siedlerchr
Siedlerchr previously approved these changes Aug 29, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
@Siedlerchr Siedlerchr dismissed stale reviews from calixtus and themself via 5285c82 August 29, 2023 19:23
@Siedlerchr Siedlerchr merged commit 39dbd0c into JabRef:main Aug 29, 2023
@papatekken papatekken deleted the fix-10176 branch August 29, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export of Preferences: User generated Export filter are duplicated
3 participants