Enable ISBN search with GVK #10211
Merged
Enable ISBN search with GVK #10211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #10123 Tested with the ISBNs
Siedlerchr
added
the
status: ready-for-review
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/main/java/org/jabref/logic/importer/fetcher/isbntobibtex/IsbnFetcher.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jabref/logic/importer/fetcher/isbntobibtex/IsbnFetcher.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jabref/logic/importer/fetcher/isbntobibtex/GVKIsbnFetcherTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jabref/logic/importer/fetcher/isbntobibtex/GVKIsbnFetcherTest.java
Show resolved
Hide resolved
|
Your code currently does not meet JabRef's code guidelines. The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues. More information on code quality in JabRef is available at https://devdocs.jabref.org/getting-into-the-code/development-strategy.html. |
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
|
Fixed most of the fetcher tests as well |
calixtus
previously approved these changes
Aug 26, 2023
|
ISBN fetcher tests are failing. Looks like the details in the entries found are better than expected. |
|
Ah forgot to adjust the composite id fetcher test |
3 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10123
Fixes #9979
Refs #10125
Tested with the ISBNs
Only the first ISBN seems odd, alternative isbn is working now
https://opac.k10plus.de/DB=2.299/SET=2/PRS=HOL/SHW?FRST=1&ACT=SRCHA
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)