-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow enabling debug logs #10137
Allow enabling debug logs #10137
Conversation
fb75a43
to
159a9f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is good. I saw, there already is a --debug switch:
if (!cli.isBlank() && cli.isDebugLogging()) { |
The check for --debug has to be done very early (due to our "broken" argument handling).
Suggestion (because of code reuse)
- Remove these three lines (the if statement)
- Use JabRef CLI directly to parse the arguemnts and handle it.
we need to test the binary that comes out of this if it works |
I tested it locally (on Linux) by creating an image with jlink, and the logs are written correctly to the selected log file. |
This reverts commit ce086a9.
xception in thread "main" java.lang.UnsupportedOperationException: Configuration cannot be changed after applying to tinylog |
Found the issue. It was the Localization.lang call |
Oops, I didn't test it after using JabRefCLI |
Just pass
--debug
to the command line.Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)