Add sublime text editor as external push application

[Siedlerchr]

Fixes #10098

Mandatory checks

• Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
• Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

[Siedlerchr]

@AdamWysokinski you can test the version here if it already works

[AdamWysokinski]

I've placed some backslashes incorrectly, I think the returned string should be:

return new String[] {commandPath, "--command \'insert {\"characters\": \"", getCiteCommand() + "{" + keyString + "}\"}\'"};

[Siedlerchr]

I installed Sublime text on mac as well and tested around, from the command line it works

/Applications/Sublime\ Text.app/Contents/SharedSupport/bin/subl  --command 'insert {"characters": "\\cite{Woblewsky2020}"}'

but not from JabRef yet, not exactly sure, Maybe it works for you?

New version wil be built automatically

[AdamWysokinski]

It doesn't work here, either. Now it switches the focus to Sublime Text, but does not paste anything. Previously it has been creating an empty file named \cite{wysokinski_2023}.

Can we log or output the command string that is being generated?

Also, the Sublime command should be subl by default (now it's sublime).

Also also, I thinks this icon: https://icon-sets.iconify.design/simple-icons/sublimetext/ is perfect for the job.

[Siedlerchr]

I tested with setting path to subl and various simple arguments like -v. That works. My valid guess is that something in the ProcessBuilder does not work the json string arg, but I don't know why.
Running it on the terminal works.
I added output for the generated String

[AdamWysokinski]

Ok, let's try again, I think I know where the problem is. Please try this:

return new String[] {commandPath, "--command \'insert {\"characters\": \"", getCiteCommand() + "\{" + keyString + "\}\"}\'"};

[Siedlerchr]

@AdamWysokinski I made it work now by starting a shell first and giving the whole application path + command string as argument for the shell.

In the log the caller string is shown as well

Regarding your string: The process builder takes the first array arg as program and every. In your case, the argument getCitecommand was interpreted as the file argument

I am having a mac and here it works, guess lInux should work as well. Windows needs probably some more escaping of double quotes

[AdamWysokinski]

It works great on Linux after entering the whole path for subl command (/usr/bin/subl).
Many thanks!

[Siedlerchr]

Now with proper icon

[koppor]

Small code style comments. If it does not work on Windows, we can fix later

[github-actions]

Your code currently does not meet JabRef's code guidelines. The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues.

More information on code quality in JabRef is available at https://devdocs.jabref.org/getting-into-the-code/development-strategy.html.

[github-actions]

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.