-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with actions on empty space of menu items #10093
Conversation
Thank you very much for the investigation! Sounds reaonsable to me to replace them with the normal entriex |
Please fix the localization test, then we will merge. |
This change fixes #8388 by removing CustomMenuItem from several context menus. This also removes the corresponding tooltips.
Thank you for your feedback. I removed the unused key and squashed my commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
You don't need to squash your commits, this is done when we merge |
Please avoid force-pushing on GitHub, since comments on commits will loose it's link. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Can you please check the documentation, if the removed tooltips should or need to be somehow replaced by some note? |
An explanation of the entries is found under Save Actions. |
This change fixes #8388 by removing CustomMenuItem from several context menus. This also removes the corresponding tool tips.
The issue is illustrated in the following image:
For "Normalize to BibTeX name format" and every entry of the "Change case" menu you have to click inside the smaller red box to actually fire the event while you can click on the bigger red box for every other entry. This is caused by the usage of CustomMenuItem which shrinks the clickable box to the actual content. It is possible to add padding to the labels to enlarge the clickable area. However, given the dynamic nature of spacing in those menus I wasn't able to get acceptable results. This would increase future maintenance efforts as well because changes would always have to address CustomMenuItems and "normal" MenuItems.
Removing CustomMenuItems on the other hand would come at the price of removing tool tips as well. Given that almost all context menu entries aren't using tool tips, I would think that this wouldn't be a big problem.
This PR doesn't cause any visual changes as far as I can tell.
Please let me know what you think about this PR and thank you very much in advance!
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)