Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get notarization running on GitHub #10041

Merged
merged 26 commits into from
Jul 1, 2023
Merged

Get notarization running on GitHub #10041

merged 26 commits into from
Jul 1, 2023

Conversation

koppor
Copy link
Member

@koppor koppor commented Jun 26, 2023

Fixes https://github.com/JabRef/jabref-issue-melting-pot/issues/24

Refs: https://docs.oracle.com/en/java/javase/20/jpackage/support-application-features.html#GUID-8D9F0607-91F4-4070-8823-02FCAB12238D

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Sorry, something went wrong.

@Siedlerchr
Copy link
Member

To test the notarization workflow we need to create a tag

@Siedlerchr
Copy link
Member

Notarization works now. just something with uploading/downloading to builds.jabref.org

@Siedlerchr
Copy link
Member

Only piece missing is to copy the work flow parts now to the mac arm

@Siedlerchr
Copy link
Member

@Siedlerchr
Copy link
Member

Run actions/download-artifact@master
Starting download for JabRef-macOS-unsigned
Error: Unable to find an artifact with the name: JabRef-macOS-unsigned

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
fix artifact name
@Siedlerchr
Copy link
Member

for arm64 I think we should rename the files before uploading etc, I am not sure if we otherwise overwrite the existing ones

@koppor koppor added this to the v5.10 milestone Jun 29, 2023
@koppor koppor mentioned this pull request Jun 29, 2023
6 tasks
koppor added 8 commits June 29, 2023 08:16

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
# Conflicts:
#	.github/workflows/deployment.yml
# Conflicts:
#	.github/workflows/deployment.yml
@koppor
Copy link
Member Author

koppor commented Jun 30, 2023

The patched macos AARM64 workflow (https://github.com/JabRef/jabref/actions/workflows/deployment-arm64.yml) needs to run on this branch (fix-notary-tool) with notarization true.

The .pkg and .dmg at https://builds.jabref.org/pull/10041/merge/ should be notarized (as of now), ,because I activated notarization.

koppor added 3 commits July 1, 2023 08:57

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@koppor
Copy link
Member Author

koppor commented Jul 1, 2023

We are continuing tweaking the build workflows (e.g., #10049). Therefore, we merge. We can add fixes if needed later.

@koppor koppor marked this pull request as ready for review July 1, 2023 20:03
@koppor koppor merged commit d2c5e23 into main Jul 1, 2023
@koppor koppor deleted the fix-notary-tool branch July 1, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants