-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get notarization running on GitHub #10041
Conversation
Co-authored-by: Christoph <[email protected]>
fix jlink command
To test the notarization workflow we need to create a tag |
Notarization works now. just something with uploading/downloading to builds.jabref.org |
Only piece missing is to copy the work flow parts now to the mac arm |
https://github.com/JabRef/jabref/actions/runs/5400189417/jobs/9808895171?pr=10041 |
Run actions/download-artifact@master |
fix artifact name
for arm64 I think we should rename the files before uploading etc, I am not sure if we otherwise overwrite the existing ones |
# Conflicts: # .github/workflows/deployment.yml
# Conflicts: # .github/workflows/deployment.yml
The patched macos AARM64 workflow (https://github.com/JabRef/jabref/actions/workflows/deployment-arm64.yml) needs to run on this branch ( The .pkg and .dmg at https://builds.jabref.org/pull/10041/merge/ should be notarized (as of now), ,because I activated notarization. |
We are continuing tweaking the build workflows (e.g., #10049). Therefore, we merge. We can add fixes if needed later. |
Fixes https://github.com/JabRef/jabref-issue-melting-pot/issues/24
Refs: https://docs.oracle.com/en/java/javase/20/jpackage/support-application-features.html#GUID-8D9F0607-91F4-4070-8823-02FCAB12238D
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)