-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with adding/deleting linked files #9731
Comments
I have a related concern: |
Another related thing that surprised me (as a new user): Deleting an entry does not delete the linked file! |
Ha, scratch that, I just found |
Similar issue if the file link is a URL. (For instance added when one does not have access to the file. Add https://doi.org/10.1007/978-3-031-36847-9_2, then use the file search functionalilty. --> html is downloaded --> cannot be deleted using Del, but with right click) |
#12324) * Just Delete link from entry if the file is no longer accesible on disk Fixes #9731 * Update CHANGELOG.md Co-authored-by: Subhramit Basu Bhowmick <[email protected]> --------- Co-authored-by: Subhramit Basu Bhowmick <[email protected]>
JabRef#12324) * Just Delete link from entry if the file is no longer accesible on disk Fixes JabRef#9731 * Update CHANGELOG.md Co-authored-by: Subhramit Basu Bhowmick <[email protected]> --------- Co-authored-by: Subhramit Basu Bhowmick <[email protected]>
JabRef version
Latest development branch build (please note build date below)
Operating system
Windows
Details on version and operating system
Windows 10
Checked with the latest development build
Steps to reproduce the behaviour
JabRef 5.10--2023-04-02--1896c99
Windows 10 10.0 amd64
Java 19.0.2
JavaFX 20+19
I observed two issues when adding and removing linked files. The first issue appears when a linked file is deleted on the level of the operating system (e.g., Windows Explorer) while JabRef is running. The respective file is not automatically removed from the linked files within JabRef. This behaviour is (probably?) fine, I guess, since otherwise JabRef would have to constantly monitor for such changes which would have a significant performance impact when dealing with large databases. But when you try to remove the respective linked file using Delin the main table view of the article, you get the message:
Error accessing file nameofyourfile
(where nameofyourfile represents the name of the file you had deleted earlier in your file manager). The only way to remove this linked file is to right-click on the file and then pressRemove link
. If multiple files have been removed with the file explorer, then you have to repeat this workaround for every single file individually (you cannot use the functionRemove link
for multiple files apparently).Error accessing file nameofyourfile
Remove link
.Remove link
to multiple files simultaneously.The second issue presents itself in larger databases (several 1000s of static groups, 10s of 1000s of items and a similar amount of linked files):
Remove from entry
+
buttonSo basically the simple action of adding and removing linked files results in major CPU load. I suspect this might be related to the auto-link feature of JabRef, but that is just speculation from my side. Note, that indexing of linked files for `Fulltext search' has been turned off, so that option cannot explain the performance problems. Also note, that the performance issue is less apparent when using small databases - you still see a small increase in CPU load, but it is far from that seen with large JabRef databases.
The text was updated successfully, but these errors were encountered: