Move "Open only one instance of JabRef" preference option to somewhere else #9306
Comments
|
If that's possible, would you like to provide more detail about this issue. Which item you consider that could be moved to 'General'? Is this the one I highlight on the snapshot?
|
|
Yes, this is the option I meant! |
|
Hi, I'm new to open source and want to try to solve some simple problems. Can you assign this issue to me? I would appreciate it! |
|
"Listen for remote operation on port xxxx" sounds very much "networky" to me. |
|
That we are using a local socket ('remote' is very misleading here) on some port is an implementation detail. We could also store the "remote command" in some file, and check that file in the running instance. But that doesn't mean it should go in the "external files" tab. The point here being that as a user I would never look under "network" to see if I can limit jabref to only one instance. |
|
Hmm. Maybe it would make sense to have this option twice in the preferences?
As a non-programmer I don't know the term "local sockets". |
|
In this context, "remote" refers to the second instance of JabRef that you start. This new instance detects another one is already running and then closes down. There is no connection over a network, nor any possibility to interact with the browser. The best way to think of it is as a glorified lock file, and "port" is the name of that lock file. "Remote" is just a very confusing name for that feature. |
|
Then I would suggest to not only move this preference to the general preferences, just like you suggested, but also to completely rewrite the description and purge all remote and port related vocabulary and replace it with something that is more easily understood. Maybe it is best to remove the "port" option completely (hence hard-code the port and hide from preferences GUI). Unless, there is a workflow that requires specific ports? |
|
Now, port can be necessary if you have another application running. |
|
That feature is also used at the web search to add entries to a running JabRef instance. Thus, it's not only about "one instance" only. For me, it is OK to move it to "general". Alternative: Just add another text for the semantics
|
koppor
added
the
good first issue
|
@DiamondMyK Move it above "Libraries" in "General"
Should be little effort only. |
Ok, I see what you mean! I will try my best to solve this problem! |
Hello, I have modified according to your suggestions! Does this meet your expectations? I will submit my changes if the requirements are met. :) @koppor
|
I am so sorry that my new text proposal was not understandsable. By "(heading)" I meant, "Use 'Single instance' as heading". Here an update on your screenshot:
Replace the skried-through text at "1" by "Enforce single JabRef instance (and allow remote operations)" and append "using" The current settings links to the help page. https://docs.jabref.org/advanced/remote. Your explanation text in the UI is nice. JabRef, however, has currently very short items. The thing is that these texts need to be translated. We therefore opted to keep a link to the help pages. If the "final" preference is there, you can file an update pull request to https://github.com/JabRef/user-documentation/blob/main/en/advanced/remote.md |
|
I really like the explanation (maybe shorten it a little bit and use smaller font) and think we should do this more often. It's also quite common to see this (eg windows settings). On the other points I agree with olly |
|
I'm sorry I misunderstood you. Now I have made new changes according to your expectations, and the changed layout is shown in the figure. Does this meet your expectations? If there are no other questions, I will submit PR. :) |
…ence option to somewhere else
|
Hello, I have completed the expectation of issue, if there is any problem, I will modify it again. Can I ask you to review and merge? I would appreciate it! :) |
|
I'll test it look later. But so far it looks good. |
…ption to somewhere else (#10602) * Fix issue #9306: Move "Open only one instance of JabRef" preference option to somewhere else * edit issue#9306 * edit * edit * edit * edit * edit * edit * edit * fix trustStoreManager NullPointerException * use one action factory --------- Co-authored-by: Siedlerchr <[email protected]>
* upstream/main: Fix CHANGELOG.md Bump commons-cli:commons-cli from 1.5.0 to 1.6.0 (JabRef#10607) Fix issue JabRef#9306: Move "Open only one instance of JabRef" preference option to somewhere else (JabRef#10602) Update README.md (JabRef#10604) Bump me.champeau.jmh from 0.7.1 to 0.7.2 Bump org.beryx.jlink from 3.0.0 to 3.0.1 Bump com.dlsc.gemsfx:gemsfx from 1.82.0 to 1.84.0 Bump org.apache.logging.log4j:log4j-to-slf4j from 2.21.0 to 2.21.1 # Conflicts: # src/main/resources/l10n/JabRef_en.properties
* upstream/main: (419 commits) Fix CHANGELOG.md Bump commons-cli:commons-cli from 1.5.0 to 1.6.0 (JabRef#10607) Fix issue JabRef#9306: Move "Open only one instance of JabRef" preference option to somewhere else (JabRef#10602) Update README.md (JabRef#10604) Bump me.champeau.jmh from 0.7.1 to 0.7.2 Bump org.beryx.jlink from 3.0.0 to 3.0.1 Bump com.dlsc.gemsfx:gemsfx from 1.82.0 to 1.84.0 Bump org.apache.logging.log4j:log4j-to-slf4j from 2.21.0 to 2.21.1 Synchronize scrollbars in the change resolver dialog (JabRef#10587) Add button for a user to reset the cite command to the default value. (JabRef#10580) openrerwrite Update .github/PULL_REQUEST_TEMPLATE.md Update PULL_REQUEST_TEMPLATE.md Update .github/PULL_REQUEST_TEMPLATE.md Update PULL_REQUEST_TEMPLATE.md Replace "fixes" by "resolves" Change JavaDoc to annotation (JabRef#10571) Fix link (JabRef#10575) Enable collecting GitHub build artifacts for forks (JabRef#10574) Fix file field merging (JabRef#10573) ... # Conflicts: # src/main/java/org/jabref/gui/fieldeditors/identifier/IdentifierEditor.java # src/main/java/org/jabref/logic/importer/WebFetchers.java
* upstream/main: (1565 commits) Enable journal information fetcher directly in popup (#10598) Make generate button wider (#10588) make openRewrite stable again Rename cleanup_pr.yml to cleanup-pr.yml Changelog Fix failing fetcher tests (#10613) ShortDoi Fix CHANGELOG.md Bump commons-cli:commons-cli from 1.5.0 to 1.6.0 (#10607) Fix issue #9306: Move "Open only one instance of JabRef" preference option to somewhere else (#10602) Update README.md (#10604) Bump me.champeau.jmh from 0.7.1 to 0.7.2 Bump org.beryx.jlink from 3.0.0 to 3.0.1 Bump com.dlsc.gemsfx:gemsfx from 1.82.0 to 1.84.0 Bump org.apache.logging.log4j:log4j-to-slf4j from 2.21.0 to 2.21.1 Synchronize scrollbars in the change resolver dialog (#10587) Add button for a user to reset the cite command to the default value. (#10580) openrerwrite Update .github/PULL_REQUEST_TEMPLATE.md Update PULL_REQUEST_TEMPLATE.md ... # Conflicts: # .devcontainer/devcontainer.json # build.gradle # src/main/java/org/jabref/gui/DefaultInjector.java # src/main/java/org/jabref/gui/libraryproperties/general/GeneralProperties.fxml # src/main/java/org/jabref/gui/libraryproperties/general/GeneralPropertiesView.java # src/main/java/org/jabref/gui/libraryproperties/general/GeneralPropertiesViewModel.java # src/main/java/org/jabref/logic/exporter/MetaDataSerializer.java # src/main/java/org/jabref/logic/importer/util/MetaDataParser.java # src/main/java/org/jabref/model/metadata/MetaData.java # src/main/java/org/jabref/preferences/JabRefPreferences.java
* upstream/main: (44 commits) change codecov (JabRef#10616) Add entry based on ISSN number JabRef#10124 (JabRef#10178) Enable journal information fetcher directly in popup (JabRef#10598) Make generate button wider (JabRef#10588) make openRewrite stable again Rename cleanup_pr.yml to cleanup-pr.yml Changelog Fix failing fetcher tests (JabRef#10613) ShortDoi Fix CHANGELOG.md Bump commons-cli:commons-cli from 1.5.0 to 1.6.0 (JabRef#10607) Fix issue JabRef#9306: Move "Open only one instance of JabRef" preference option to somewhere else (JabRef#10602) Update README.md (JabRef#10604) Bump me.champeau.jmh from 0.7.1 to 0.7.2 Bump org.beryx.jlink from 3.0.0 to 3.0.1 Bump com.dlsc.gemsfx:gemsfx from 1.82.0 to 1.84.0 Bump org.apache.logging.log4j:log4j-to-slf4j from 2.21.0 to 2.21.1 Synchronize scrollbars in the change resolver dialog (JabRef#10587) Add button for a user to reset the cite command to the default value. (JabRef#10580) openrerwrite ...
Is your suggestion for improvement related to a problem? Please describe.
The option to limit to only one running instance of JabRef is currently under the "Network" tab, which is highly confusing since from a users perspective there is nothing "networky" going on.
Describe the solution you'd like
Move it to another tab, maybe "General"?
The text was updated successfully, but these errors were encountered: