Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore unnecessary library modification notifications? #9159

Closed
2 tasks done
ilippert opened this issue Sep 19, 2022 · 5 comments · Fixed by #9165
Closed
2 tasks done

ignore unnecessary library modification notifications? #9159

ilippert opened this issue Sep 19, 2022 · 5 comments · Fixed by #9165
Labels
bug Confirmed bugs or reports that are very likely to be bugs export / save

Comments

@ilippert
Copy link
Contributor

ilippert commented Sep 19, 2022

JabRef version

Other (please describe below)

Operating system

GNU / Linux

Details on version and operating system

JabRef 5.8--2022-09-15--853338a Linux 5.19.8-200.fc36.x86_64 amd64 Java 18.0.2.1 JavaFX 19+11

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

change the metadata of the library (within JabRef) and you (at least I) get a library notification message. I do not see how/why this is necessary. Obviously, the metadata changes when I save the library.

Appendix

...

Screencast.from.19-09-22.14.51.51.webm
@ilippert
Copy link
Contributor Author

Now with screencast (updated), nothing typed. and then pressed CTRL+S and a few moments later the modification claim occurs.

@Siedlerchr Siedlerchr added the bug Confirmed bugs or reports that are very likely to be bugs label Sep 19, 2022
@Siedlerchr
Copy link
Member

Can confirm this.

@HoussemNasri
Copy link
Member

@Siedlerchr Wasn't this issue fixed by #9067?

@Siedlerchr
Copy link
Member

Yes it should have been. I don't know what's wrong with it now.

@HoussemNasri
Copy link
Member

It appears that Save actions and Library mode are always detected as changed. I got the same result when I added a new string from the library properties dialog without changing the library mode or the save actions.

Siedlerchr added a commit that referenced this issue Sep 19, 2022
Fixes #9159

Generate new equals, hashcode for FieldFormatterCleanup and toString methods
@koppor koppor moved this to Done in Prioritization Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs export / save
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants